Repository navigation
Faster Tests (DjangoCon) - #1602
Merged
Merged
Conversation
…sentry-python into antonpirker/tests-experiments
antonpirker
marked this pull request as ready for review
September 16, 2022 12:04
antonpirker
commented
Sep 16, 2022
sl0thentr0py
requested changes
Sep 16, 2022
sl0thentr0py
left a comment
sl0thentr0py
left a comment
Member
There was a problem hiding this comment.
ok firstly, great work!
just some random comments and one more here.
Can you document in the PR description / contributing guide what we need to do if we add/remove a certain tox configuration in tox.ini? (basically just run the script again, I guess.)
Contributor
Author
|
I have now made it so the CI fails when |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1499