Skip to content

fix(pii): Filter URL signatures in collected data - #2293

Merged
Litarnus merged 1 commit into
getsentry:masterfrom
smotim:fix/filter-url-signatures
Oct 27, 2026
Merged

Litarnus merged 1 commit into
getsentry:masterfrom
smotim:fix/filter-url-signatures

Conversation

@smotim

@smotim smotim commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Description

Adds signature to the sensitive deny list, so URL signatures are filtered when data_collection collects query strings, headers and cookies.

A URL signature is a credential in its own right: anyone holding the URL can use it until it expires. Two common cases currently pass through unfiltered, since none of the existing terms match these keys:

  • Laravel signed routes (URL::signedRoute(), URL::temporarySignedRoute()) put it into ?expires=…&signature=…. These are typically download, unsubscribe and email verification links, so an error on such a route sends a working link along with the event.
  • Presigned S3 URLs (and S3-compatible storage) carry X-Amz-Signature, which ends up in the URL of outgoing Guzzle spans.

This follows the PHP-specific remember term: the denylist in the spec is the minimum an SDK must filter. If you'd rather have the term in the cross-SDK data collection spec first, I'm happy to propose it there instead.

Laravel signed routes carry the signature in `?signature=`, presigned S3
URLs in `X-Amz-Signature`. Either one is a working credential until the
URL expires, and none of the existing deny list terms matched it.
@Litarnus
Litarnus enabled auto-merge (squash) October 27, 2026 17:12

@Litarnus Litarnus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! I agree that this is something that can easily be overlooked so it's good to add it here

@Litarnus
Litarnus merged commit 0f80ff4 into getsentry:master Oct 27, 2026
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants