Repository navigation
fix(pii): Filter URL signatures in collected data - #2293
Merged
Merged
Conversation
Laravel signed routes carry the signature in `?signature=`, presigned S3 URLs in `X-Amz-Signature`. Either one is a working credential until the URL expires, and none of the existing deny list terms matched it.
Litarnus
enabled auto-merge (squash)
October 27, 2026 17:12
Litarnus
approved these changes
Oct 27, 2026
Litarnus
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, thank you! I agree that this is something that can easily be overlooked so it's good to add it here
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
signatureto the sensitive deny list, so URL signatures are filtered whendata_collectioncollects query strings, headers and cookies.A URL signature is a credential in its own right: anyone holding the URL can use it until it expires. Two common cases currently pass through unfiltered, since none of the existing terms match these keys:
URL::signedRoute(),URL::temporarySignedRoute()) put it into?expires=…&signature=…. These are typically download, unsubscribe and email verification links, so an error on such a route sends a working link along with the event.X-Amz-Signature, which ends up in the URL of outgoing Guzzle spans.This follows the PHP-specific
rememberterm: the denylist in the spec is the minimum an SDK must filter. If you'd rather have the term in the cross-SDK data collection spec first, I'm happy to propose it there instead.