Repository navigation
fix(sveltekit): Resolve Handle and ResolveOptions types on SvelteKit 3 - #26085
Merged
Merged
Conversation
SvelteKit 3 moved Handle and ResolveOptions from @sveltejs/kit to @sveltejs/kit/hooks, so the SDK's declarations failed to resolve them and sentryHandle() and initCloudflareSentryHandle() returned any. SvelteKit 2 doesn't export them from @sveltejs/kit/hooks, so derive them from sequence, which both majors export from there. Fixes #25924 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
bugbot run |
Contributor
size-limit report 📦Compared: 07f58fa (PR test merge using develop at b9d0f82) Against: b9d0f82 (develop) · base run #64917 ✅ Baseline matches: this diff contains only this PR's changes.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Type-check that sentryHandle() and initCloudflareSentryHandle() don't resolve to a type that accepts anything in the SvelteKit 3 e2e app. Only the sentryTypes.ts file is checked, because the app's full svelte-check run has unrelated errors. Refs #25924 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit a54cf8b. Configure here.
chargome
marked this pull request as ready for review
November 4, 2026 10:33
chargome
requested review from
Lms24,
andreiborza,
logaretm,
mydea,
nicohrubec and
s1gr1d
and removed request for
a team
November 4, 2026 10:33
nicohrubec
approved these changes
Nov 4, 2026
51 tasks done
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: SvelteKit 3 moved
HandleandResolveOptionsfrom@sveltejs/kitto@sveltejs/kit/hooks. Our declarations still import them from@sveltejs/kit, so on Kit 3 the import fails. WithskipLibCheck,sentryHandle()andinitCloudflareSentryHandle()then quietly returnany. Kit 2 doesn't export these types from/hooks, so no single import path works on both majors. Instead we take them fromsequence, which both majors export from/hooks.Closes #25924