Repository navigation
test(bundler-plugins): Add integration tests for sourcemaps.assets and sourcemaps.ignore - #25916
Merged
timfish merged 1 commit intoNov 10, 2026
Conversation
…and `sourcemaps.ignore` The bundler plugin integration tests had no fixture that set either option, and the unit tests only check that the globs reach the glob call. Nothing asserted which chunks end up uploaded. Each of the Rollup, Rolldown, Vite, webpack and esbuild fixtures gets a two-entry build with source maps on. One test ignores `entry2.js`, the other restricts `assets` to `entry1.js`. The `sentry` CLI stub can now record the `sources` of every map in the upload directory, opt-in through `SENTRY_TEST_RECORD_UPLOADED_SOURCES`, so the snapshots show which chunks were uploaded and that every map stays in the output.
Contributor
size-limit report 📦Compared: 7061d1d (PR test merge using develop at 30cfb4c) Against: 30cfb4c (develop) · base run #64245 ✅ Baseline matches: this diff contains only this PR's changes.
|
timfish
marked this pull request as ready for review
October 29, 2026 19:17
timfish
requested review from
andreiborza,
chargome,
isaacs,
logaretm,
msonnb and
nicohrubec
and removed request for
a team and
msonnb
October 29, 2026 19:17
isaacs
reviewed
Oct 29, 2026
isaacs
left a comment
isaacs
left a comment
Member
There was a problem hiding this comment.
Just a comment, going to pivot and review the stack first. Re-requesting from myself so that it stays on my queue 👍
| output: { | ||
| dir: "out/sourcemaps-ignore", | ||
| chunkFileNames: "[name].js", | ||
| sourcemap: true, |
Member
There was a problem hiding this comment.
I was going to raise that the fixtures never take the staged upload path, but I think that's covered by your stack? If this PR is meant only as a baseline before the stack, then we should maybe say that in the description, and make sure each stack PR adds the staged variant.
Collaborator
Author
There was a problem hiding this comment.
I was going to raise that the fixtures never take the staged upload path, but I think that's covered by your stack?
The staged upload path will be covered in the stack but I haven't got that far yet. I've added a ref. to this in the description.
I think eventually It would be good to move Roll{up,down}, Vite and webpack to only use the staged path, but that's a behavioural change because we would stop picking up maps that weren't in the build. I would say that's desirable, but it is a change. It looks like esbuild, Turbopack, SvelteKit and Nuxt will not be able to go this route though 🤔
isaacs
self-requested a review
October 29, 2026 19:55
timfish
added a commit
that referenced
this pull request
Nov 6, 2026
…r upload in the Rollup plugin (#25645) Part of the stack for #25609. When the Rollup or Rolldown output has no `sourcemap` setting and an upload can run, the plugin switches the output to hidden source maps, copies each chunk and its map into the upload staging folder from a `generateBundle` hook that runs last, and drops the map asset so it is never written. A map the plugin turned on never reaches the output, not even for chunks that `sourcemaps.assets` or `sourcemaps.ignore` keep out of the upload or that the plugin cannot prepare. `deleteSourcemapsAfterUpload: true` also removes maps the user enabled, but only for chunks that were uploaded; the rest stay, with a warning for a chunk the plugin cannot prepare. `generate()` drops the maps the plugin turned on, so callers that write the result themselves get what they configured. Decisions and stagings are recorded per output, told apart by `format`, `entryFileNames`, `chunkFileNames` and `file`, because several outputs can write into one directory at once with different settings. Staging applies `sourcemaps.assets` and `sourcemaps.ignore` through the matcher that `glob` exports for its own `ignore` option, with the same dot-file rules as the upload from disk: `assets` skips dot files and folders unless a pattern names them, and `ignore` matches them. SvelteKit and Nuxt pass `deleteSourcemapsAfterUpload: false` because they need the map files on disk after the Vite build; the other framework SDKs set the bundler's source map option themselves, which the plugin never deletes, so their builds do not change until each one migrates in its own PR. Integration fixtures cover `ignore` and `assets` on the staged path and mixed outputs into one directory; the CLI stub change comes from #25916 and drops out when that merges.
chargome
approved these changes
Nov 10, 2026
timfish
deleted the
feat/bundler-plugin-integration-tests-assets-ignore
branch
November 10, 2026 07:26
51 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bundler plugin integration tests had no fixture that set
sourcemaps.assetsorsourcemaps.ignore, and the unit tests only check that the globs reach the glob call. Nothing asserted which chunks end up uploaded, which let a gap in the staged upload work go unnoticed.Each of the Rollup, Rolldown, Vite, webpack and esbuild fixtures gets a two-entry build with source maps on. One test ignores
entry2.js, the other restrictsassetstoentry1.js. ThesentryCLI stub can now record thesourcesof every map in the upload directory, opt-in throughSENTRY_TEST_RECORD_UPLOADED_SOURCES, so the snapshots show which chunks were uploaded and that every map stays in the output.These stacked PRs will need their own tests to cover the staged upload route.