Repository navigation
fix(solidstart): Serve the managed tunnel under Vite's base on SolidStart 2 - #25848
Merged
Merged
Conversation
…tart 2 SolidStart 2 serves the app under Vite's `base`, but the browser fell back to the root and the server used Nitro's `baseURL`, so behind a proxy that only forwards the base path the tunnel requests never arrived. `sentrySolidStart()` now defines the base path for the browser and sets it as Nitro's `sentryTunnelBasePath` runtime config, which `@sentry/nitro` serves the tunnel under instead of `baseURL`.
Contributor
Optional E2E testsAll optional checks were successful. 1 successful. See the run. Successful checks
|
Contributor
size-limit report 📦Compared: 30227fc (PR test merge using develop at 02d3290) Against: 02d3290 (develop) · base run #64011 ✅ Baseline matches: this diff contains only this PR's changes.
|
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 6719136. Configure here.
logaretm
marked this pull request as ready for review
October 28, 2026 17:45
logaretm
requested review from
Lms24,
andreiborza,
chargome,
isaacs,
msonnb and
nicohrubec
and removed request for
a team
October 28, 2026 17:45
nicohrubec
approved these changes
Oct 29, 2026
Lms24
approved these changes
Oct 29, 2026
51 tasks done
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On SolidStart 2 the managed tunnel ignored Vite's
base, so behind a proxy that only forwards the base path the browser's envelopes never arrived. This is the last hold out.This is fixed by passing the base path to the browser and to
@sentry/nitrothrough Nitro's runtime config. I added tunnel e2e variants for prod and dev under/app, and the prod one fails before the fix.closes #25467