fix(server-utils): Map Flue messages and token usage to the gen_ai conventions - #24992
Merged
Merged
Conversation
JPeer264
added this pull request to stack #25002
October 2, 2026 13:14
JPeer264
removed this pull request from stack #25002
October 2, 2026 13:31
JPeer264
added this pull request to stack #25004
October 2, 2026 13:57
JPeer264
force-pushed
the
jp/flue-map-messages-conventions
branch
from
October 3, 2026 16:23
3a5576b to
203f215
Compare
JPeer264
changed the title
JPeer264
removed this pull request from stack #25004
October 5, 2026 07:21
JPeer264
added this pull request to stack #25029
October 5, 2026 07:22
JPeer264
marked this pull request as ready for review
October 5, 2026 08:48
JPeer264
requested review from
andreiborza and
mydea
and removed request for
a team
October 5, 2026 08:48
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
JPeer264
force-pushed
the
jp/flue-map-messages-conventions
branch
2 times, most recently
from
October 5, 2026 11:22
38396de to
02668a5
Compare
andreiborza
reviewed
Oct 5, 2026
andreiborza
left a comment
andreiborza
left a comment
Member
There was a problem hiding this comment.
Generally LGTM, just some comments around types.
Comment on lines
+3
to
+10
| /** A message in the gen_ai conventions shape, see https://develop.sentry.dev/sdk/telemetry/traces/modules/ai-agents/. */ | ||
| export interface GenAiMessage { | ||
| role: string; | ||
| parts: GenAiMessagePart[]; | ||
| finish_reason?: string; | ||
| } | ||
|
|
||
| export type GenAiMessagePart = Record<string, unknown> & { type: string }; |
Member
There was a problem hiding this comment.
m: I think we should find a more central place for these, maybe `packages/sever-utils/src/ai/types.ts?
|
|
||
| /** A message in the gen_ai conventions shape, see https://develop.sentry.dev/sdk/telemetry/traces/modules/ai-agents/. */ | ||
| export interface GenAiMessage { | ||
| role: string; |
Member
There was a problem hiding this comment.
m: Can we type this stronger than string?, i.e.
Suggested change
| role: string; | |
| role: assistant | system | tool | user; |
| finish_reason?: string; | ||
| } | ||
|
|
||
| export type GenAiMessagePart = Record<string, unknown> & { type: string }; |
Member
There was a problem hiding this comment.
m: Can we type this stronger? i.e.
Suggested change
| export type GenAiMessagePart = Record<string, unknown> & { type: string }; | |
| export type GenAiMessagePart = Record<string, unknown> & { type: blob | object | reasoning | text | tool_call | tool_call_response }; |
…nventions Flue records its turn messages in pi-ai's shape, with a `toolResult` role and `toolCall` parts, and Sentry renders neither, so tool calls and tool results were missing from the conversation views. Its token counts come from pi-ai too, whose `input` leaves the cached tokens out while the conventions count them in, so input tokens and input cost were too low whenever prompt caching was active. A shared pi-ai mapper now translates messages, usage and the finish reason to the conventions, and the tool span records the result the model receives instead of Flue's internal result wrapper. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
JPeer264
force-pushed
the
jp/flue-map-messages-conventions
branch
from
October 6, 2026 07:08
793f315 to
e8f0757
Compare
andreiborza
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flue records the messages of its turns in pi-ai's own shape, with a
toolResultrole andtoolCallparts. Sentry's AI views only render the gen_ai conventions shape, so tool calls and tool results were missing from Flue conversations, and the tool result showed up with an invalid role. This maps the input and output messages to the conventions, the way #24352 did for Google GenAI.The token counts come from pi-ai too. Its
inputleaves the cached tokens out, whilegen_ai.usage.input_tokensincludes them by definition, so input tokens and input cost were too low whenever prompt caching was active (the default for Anthropic models). The finish reason is mapped as well (toolUsebecomestool_call), and the tool span now records the result the model receives (Flue'seffectiveResult) instead of the internal{ content, details }wrapper.The mapper lives in
ai/pi-ai/because pi-durable sends the same shapes, and its integration uses it too.🤖 Generated with Claude Code