Repository navigation
Conversation
…ONTIER-5760) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every page served through the shared layout now carries the values of the primary Grail tags on
window.dtinfo, next to the existingappName. A per-frontend RUM capture rule (FRONTIER-5761) can then copy them onto user events asevent_properties.*. Ships as@fs/react-scripts8.19.0. That version assumes #433 (8.18.0) merges first; if it doesn't, this PR will be re-bumped.window.dtinfo.sid<blueprint>/<system>/<service>, e.g.frontier-africa/beta/africaFS_BLUEPRINT_NAME,FS_SYSTEM_NAME,FS_SERVICE_NAMEwindow.dtinfo.environmentdev|test|prodFS_ENVIRONMENT_NAME, elseFS_SYSTEM_NAMEmappedint→dev,beta→test,prod→prod@fs/startup4.4.0 derives them, so RUM events and back-end records carry the same values. Only theFS_*config vars are read, neverTARGET_ENV.sidis positional, so it stops at the first missing or malformed segment and is not set when the blueprint is missing. An unmapped system leavesenvironmentunset; an untagged event is better than a mislabelled one.appName, not behindNODE_ENVor the RUM flag, because capture rules read a plain global.fsetgrp_id(the project group is not on the Heroku deploy path yet, FRONTIER-4446), the capture rules themselves (FRONTIER-5761), and the RUM loading arms indynatrace.ejs.Verification
frontier-app-react(@fs/react-scripts8.17.0 installed) was run withnpm start, with the installedlayout/viewssymlinked to this branch. The dev server mounts Snow, so this is the samelayout.ejsrender path production uses.FS_BLUEPRINT_NAME=frontier-app-react FS_SYSTEM_NAME=intwindow.dtinfo.sid = "frontier-app-react/int",window.dtinfo.environment = "dev"FS_BLUEPRINT_NAME=frontier-app-react, no systemwindow.dtinfo.sid = "frontier-app-react", noenvironmentappNameFor case 1, the browser reads
window.dtinfoas{"appName":"frontier-app-react","sid":"frontier-app-react/int","environment":"dev"}.The repo has no lint script and no local test suite (root
npm testis a no-op), so CI's prerelease and scaffold smoke test is the automated check.Depends on #433
build-and-publishfails atInstall, before it reaches anything this PR changes. JFrog curation now returns 403 forwebsocket-driver-0.7.5.tgz, whichfrontierMasterpulls in through webpack-dev-server 4. That makes every PR offfrontierMasterred, not just this one. #433 (webpack-dev-server 6) dropswebsocket-driver, and its CI passes.Merge #433 first, then rebase this branch onto
frontierMaster. CI should pass after that, and the 8.19.0 bump here becomes the correct next version.🤖 Generated with Claude Code