You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Promote integer samples before finite-difference arithmetic - #239
finitediff allocates a floating derivative buffer but evaluates its subtraction and weighted sums in the input integer dtype first. Those intermediate values can wrap, or raise on negative coefficients with unsigned inputs. For example:
Convert integer samples to a floating working buffer before stencil arithmetic. Existing floating inputs retain their current dtype and path; the caller's array is preserved. Add analytic quadratic and signed/unsigned regressions across stencil orders, repeated smoothing and a non-leading time axis.
Validation: all 258 tests pass. Pylint was run against both sources; existing diagnostics remain. Across 360 recorded-PCM configurations, 48 exceptions and 96 incorrect derivative runs become zero; 76 incorrect strongest-derivative selections are corrected. Direct Python-integer stencil sums independently check one-pass derivatives. All 36 float32/float64 control hashes remain exact. The existing convex-solver accuracy warning remains unchanged.
This gets at a wider issue: I was never testing that integer input and float input would return the same thing. Claude found a few other methods where truncation or overflow could occur, so I've taken a pass over everything now and replaced your test with something simpler that generalizes more.
Thanks for extending this across the other methods. Replayed the exact merge fc6b96e on three recorded PCM speech clips. The original stencil workload's 48 exceptions and 96 incorrect runs are gone. A separate 504-case replay covering finite differences, Butterworth, kernel smoothing, spectral and wavelet methods removes all 308 integer-versus-float mismatches; all 84 float64 controls are byte-identical to the merge parent. This checks numerical input consistency, not derivative estimation quality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
finitediffallocates a floating derivative buffer but evaluates its subtraction and weighted sums in the input integer dtype first. Those intermediate values can wrap, or raise on negative coefficients with unsigned inputs. For example:Before:
[246. 246. 246. 246. 246.]. After:[-10. -10. -10. -10. -10.].Convert integer samples to a floating working buffer before stencil arithmetic. Existing floating inputs retain their current dtype and path; the caller's array is preserved. Add analytic quadratic and signed/unsigned regressions across stencil orders, repeated smoothing and a non-leading time axis.
Validation: all 258 tests pass. Pylint was run against both sources; existing diagnostics remain. Across 360 recorded-PCM configurations, 48 exceptions and 96 incorrect derivative runs become zero; 76 incorrect strongest-derivative selections are corrected. Direct Python-integer stencil sums independently check one-pass derivatives. All 36 float32/float64 control hashes remain exact. The existing convex-solver accuracy warning remains unchanged.