You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Currency Exchange] - last exercises too complex #2946
The last two methods you have to create: exchangeable_value and non_exchangeable_value - are both far too complicated in their requirements.
I struggled to understand what was going on when I did them (I'm proficient at Python), and both of the friends I'm mentoring struggled as well, and we all three of us have at least a Masters in a STEM subject! I'm not bragging about our education there; I'm saying that if multiple people with advanced technical degrees struggle on a "learning" exercise, it's far too complicated for something that's meant to be teaching a basic concept.
When I look at it now a few months later, including my solution, I still have no idea what they're doing without spending a few minutes staring at them.
I would instead suggest it's worth demonstrating things like:
If you apply the following operators (* + -) to two ints, you get an int back, but apply / to two ints and you get a float back. That kind of thing.
If you are requesting support, we will be along shortly to help. (generally within72 hours,often more quickly).
Found a problem with tests, exercises or something else?? 🎉
◦ We'll take a look as soon as we can & identify what work is needed to fix it. (generally within72 hours).
◦ If you'd also like to make a PR to fix the issue, please have a quick look at the Pull Requests doc. We 💙 PRs that follow our Exercism & Track contributing guidelines!
Here because of an obvious (andsmallset of) spelling, grammar, or punctuation issues with one exercise,
concept, or Python document?? 🌟 Please feel free to submit a PR, linking to this issue. 🎉
‼️Please Do Not‼️
❗ Run checks on the whole repo & submit a bunch of PRs.
This creates longer review cycles & exhausts reviewers energy & time.
It may also conflict with ongoing changes from other contributors.
❗ Insert only blank lines, make a closing bracket drop to the next line, change a word
to a synonym without obvious reason, or add trailing space that's not an EOL for the very end of text files.
❗ Introduce arbitrary changes "just to change things" .
...These sorts of things are not considered helpful, and will likely be closed by reviewers.
For anything complicated or ambiguous, let's discuss things -- we will likely welcome a PR from you.
Here to suggest a feature or new exercise??Hooray! Please keep in mind Chesterton's Fence. Thoughtful suggestions will likely result faster & more enthusiastic responses from maintainers.
💛 💙 While you are here... If you decide to help out with other open issues, you have our gratitude 🙌 🙌🏽.
Anything tagged with [help wanted] and without [Claimed] is up for grabs.
Comment on the issue and we will reserve it for you. 🌈 ✨
Activity
github-actions commentedon Feb 19, 2022
🤖 🤖
Hi! 👋🏽 👋 Welcome to the Exercism Python Repo!
Thank you for opening an issue! 🐍 🌈 ✨
◦ We'll take a look as soon as we can & identify what work is needed to fix it. (generally within 72 hours).
◦ If you'd also like to make a PR to fix the issue, please have a quick look at the Pull Requests doc.
We 💙 PRs that follow our Exercism & Track contributing guidelines!
concept, or Python document?? 🌟
Please feel free to submit a PR, linking to this issue.🎉 ❗ Run checks on the whole repo & submit a bunch of PRs.
This creates longer review cycles & exhausts reviewers energy & time.
It may also conflict with ongoing changes from other contributors.
❗ Insert only blank lines, make a closing bracket drop to the next line, change a word
to a synonym without obvious reason, or add trailing space that's not an EOL for the very end of text files.
❗ Introduce arbitrary changes "just to change things" .
...These sorts of things are not considered helpful, and will likely be closed by reviewers.
Thoughtful suggestions will likely result faster & more enthusiastic responses from maintainers.
💛 💙 While you are here... If you decide to help out with other open issues, you have our gratitude 🙌 🙌🏽.
Anything tagged with
[help wanted]and without[Claimed]is up for grabs.Comment on the issue and we will reserve it for you. 🌈 ✨
kotp commentedon Feb 19, 2022
I know you said "that kind of thing" but definitely not this thing. Because it is not true.
[-]Currency Exchange - last exercises too complex[/-][+][Currency Exchange] - last exercises too complex[/+]narenkeshav commentedon Feb 21, 2022
I concur. I found
exchangeable_valueto have a lack proper description in the final part.BethanyG commentedon Feb 21, 2022
@mohmad-null -- since you also filed issue #2804, it was probably better to reopen that one instead of filing a new issue against the same exercise.
Consolidating related issues under #2951. Closing this to reduce noise and focus on the redesign.
mohmad-null commentedon Feb 25, 2022
Oh; I'd completely forgotten about that issue. I suppose that just re-enforces my point that about that particular exercise. :-)