Skip to content

Palindrome Product Exercise (es6) #1

Closed

Description

@wilmoore

Todos

  • Build a sane test workflow.
  • Clean up exercise.

Activity

  1. kytrinyx commented on May 22, 2014

    @kytrinyx
    Member

    LGTM! <3

  2. wilmoore commented on May 22, 2014

    @wilmoore
    Author

    The best part of this refactor doesn't work in any of the transpilers I've tried. See: google/traceur-compiler#1035 for further details.

  3. wilmoore commented on May 22, 2014

    @wilmoore
    Author

    I was using legacy firefox only syntax so I've now got the es6 module compiling to ES5/CommonJS.

  4. kytrinyx commented on May 23, 2014

    @kytrinyx
    Member

    Ah, ok. I'll just leave you to merge it when you feel it's ready.

  5. wilmoore commented on May 28, 2014

    @wilmoore
    Author

    PR has been created. I'd like to give it some soak time before merging just to be sure we like it.

  6. rchavarria commented on Jul 2, 2015

    @rchavarria
    Contributor

    Hi,
    Sorry if this is not the right place, but I'm not sure where to ask.
    How could I run my production code against the tests provided by exercism?
    I've tried to run them with the command under the ecmascript/palindrome-products folder:

    jasmine-node .
    

    But I get this error:

    C:\Users\rchavarria\exercism\ecmascript\palindrome-products\palindrome-products.js:7
    function generate({ minFactor = 1, maxFactor = Number.MAX_VALUE }) {
                      ^
    Exception loading: C:\Users\rchavarria\exercism\ecmascript\palindrome-products\palindrome-products_test.spec.js
    [SyntaxError: Unexpected token {]
    

    It seems the ECMAScript 6 code is not transpiled to ECMAScript 5 before running the tests, but I don't know how to tell traceour to do it.

    Thanks in advance.

  7. kytrinyx commented on Jul 2, 2015

    @kytrinyx
    Member

    @rchavarria You'll probably get more help asking in the support channel: https://gitter.im/exercism/support -- if not, you might also be able to get some help on StackOverflow (not the exercism-specific part, but there are a lot of knowledgable people who, if you tell them what the filenames and paths and bits of code are, could probably give you an answer quickly.

  8. rchavarria commented on Jul 3, 2015

    @rchavarria
    Contributor

    Ok, thanks. I'll try first the support channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions