Skip to content

Clean up 'backend' fixture - #664

Merged
florimondmanca merged 2 commits into
masterfrom
cleanup-backend-fixture
Dec 21, 2019
Merged

florimondmanca merged 2 commits into
masterfrom
cleanup-backend-fixture

Conversation

@florimondmanca

Copy link
Copy Markdown
Contributor

#615 removed passing backend=... to most of our tests, but we still had a backend fixture. It was declared as a test function parameter but not actually used.

This PR replaces this fixture with another one, async_environment. It is invoked using @pytest.mark.usefixtures() and should be applied when we want to run a test against all async environments.

@florimondmanca florimondmanca added tooling Changes to our CI/CD, tests setup, etc. refactor Issues and PRs related to code refactoring labels Dec 20, 2019
Comment thread tests/conftest.py Resolved

@lovelydinosaur lovelydinosaur left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice change!

@florimondmanca
florimondmanca merged commit d0427be into master Dec 21, 2019
@florimondmanca
florimondmanca deleted the cleanup-backend-fixture branch December 21, 2019 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Issues and PRs related to code refactoring tooling Changes to our CI/CD, tests setup, etc.

Development

Successfully merging this pull request may close these issues.

2 participants