Repository navigation
chore(template): move the control box to Node 24.22.1 - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
templates/control.tsmoves the control box's Node fromv24.21.0tov24.22.1. The driver runsdriver/e2b-helper.mjson this Node for every E2B call (create, connect, list, kill), carrying the E2B API key. Node verifies TLS against its own bundled roots, not the box'sca-certificates, so 24.21.0 still trusts the compromised eMudhra intermediates. 24.22.1 is the patched 24.x in the disclosure: https://emudhra.we-have-a-problem.com/.This is the follow-up to #5. #5 patched the Rust driver's rustls-webpki, but the driver only uses rustls for its gRPC link to the gateway on
127.0.0.1, under per-session certificates it generates itself. The public-CA path to E2B goes through this Node.How I verified it
sha256sum -cagainst nodejs.org'sSHASUMS256.txt.https.get, withNODE_OPTIONSandNODE_EXTRA_CA_CERTSunset) against the disclosure's test hosts:dv-g3b-emudhra.we-have-a-problem.comis trusted (HTTP 200).dv-g3b-aaa-emudhra...are both rejected (CERT_REVOKED).api.e2b.app.npm install e2b@2.51.0ande2b-helper.mjs. Then I ran the read-onlylistop against prod E2B, which returned{"ok":true,"sandboxes":[]}.Residual risk
npm run build:binaries(picks up chore(deps): bump rustls-webpki to 0.103.16 #5) andnpm run template:control(bakes this Node and that driver intoopenshell-control). I haven't run them. There's no npm or crates.io package to publish.v0.1.2lock rustls-webpki 0.103.15 and webpki-roots 1.0.7. Upstream's fix (fix(deps): update webpki to distrust compromised emSign CAs ai-openshell/openshell#4794) first ships in the prereleasev0.1.6-pre.3, so moving that pin is a separate upgrade.