Skip to content

Tighten redrive successor validator: cancellation lineage, root, step and field binding #239

Closed

Description

@rmcdaniel

Found by the General interim review of sdk-python#238 (comment 6618095364). These test-validator strictness gaps are shared across the SDK successor validators (sdk-rust assert_valid_redrive_successor, sdk-php RedriveSuccessorHistory, sdk-python check_redrive_successor). They are non-blocking, because none affects the non-leakage claim.

Gaps

  1. Root binding: a non-null parent_request_id skips the root_request_id check.
  2. Lineage: only the last lineage entry is checked. A lineage with a source-run entry prepended is accepted.
  3. Delivery step: a delivery to a step the successor already completed is accepted, and so is a schedule recorded after a delivery to the resume step.
  4. Unchecked fields: request command_type, delivery call_kind, and the context requested_at and schema are unchecked or only checked when present.
  5. Copied timer: a copied TimerScheduled carrying timer_kind or cancellation_scope_id should be refused, because Core isPlainTimer (FailedRunRedrivePlan.php:497 at 28893f97) excludes those timers. sdk-python#238 fixes this; check whether this SDK needs it too.

Done when

Each gap is closed in this SDK's validator with a fail-before counterfactual, matching Core 28893f97 shapes, and the semantics are aligned across the three SDKs.

🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions