Repository navigation
Conversation
rmcdaniel
left a comment
There was a problem hiding this comment.
Bounded ordinary source/help review at exact 7d85685f84989132afda46cadb92328c191e0b5e: one acceptance gap, detailed inline. The starting path does not include the history step explicitly required by #159.
I read the seven changed files and the surrounding lookup/dispatch, descriptor, output-mode and connection-resolution code. The suggestion ranking changes only the visible NotFound alternatives, after exact/alias/abbreviation lookup; existing confirmation and noninteractive failure paths remain. Human workflow:start help puts the concrete invocation and common controls first. Raw and namespace listings retain their layout paths. --output=json and the retained --json flag both select JSON; http://localhost:8080 is the actual unconfigured target after the existing explicit/environment/profile precedence. Catalog comparison confirms only the declared workflow:start help field changes, and its reviewed reference/candidate pair matches base/head. Display exceptions are confined to stdout_text or stderr; exit, JSON, config and error-category comparisons remain.
This is source/help review only. I ran no compiler, CLI binary, Server, SDK or test suite and do not independently certify the reported CI/platform/parity results. The #161 first-start dependency, PHP setup block and release/profile gates remain separate. Please add the missing history discovery step and update the focused assertion before this review can pass.
rmcdaniel
left a comment
There was a problem hiding this comment.
Bounded ordinary source/help countercheck: PASS at exact 9e6bde1044edf6848a9f1adb4c5e7a8be1f7e96c.
The prior #159 acceptance finding is closed. The initial human path now includes workflow:history, while dw env:set profile guidance remains visible before the full options/reference. The focused assertion checks history discovery and visible profile guidance instead of fixing the row count at six. Raw, namespace-specific and error-header paths remain outside the onboarding addition.
I independently compared the exact successor against reviewed 7d85685f: one file only, three additions/nine deletions, covering that array and its focused assertion. All other lookup, catalog, descriptor and parity files are unchanged, so the remaining source/help conclusions in my earlier review carry forward without a new finding.
This is a source/help verdict. I ran no build, CLI, Server, SDK or tests and do not independently certify the reported nine descriptor tests. Current-head qualification, parent #161's first-start journey, the shared setup block and existing administrator/package/release gates remain separate.
|
Security/source review: PASS for exact The command lookup change is display-only after normal resolution has failed. Exact names, aliases, unambiguous abbreviations, namespace refusal, ambiguity handling, hidden-command filtering and the noninteractive failure remain unchanged. Suggestions are static catalog names; prioritizing the exact requested namespace and edit distance cannot execute a suggestion. The new control explicitly distinguishes the existing abbreviation dispatch from typo refusal. The first-use and The parity exceptions are closed to Delivery remains correctly held behind #161 composition: this exact base still has the pre-#161 Laravel-project |
|
|
Security bounded source/composition/runner review: PASS for exact The composition boundary is closed:
The runner extension exercises the actual first-use path rather than bypassing profile resolution. Under an isolated HOME/config/temp and empty PATH it saves and selects Independent source checks pass: The live platform jobs, central #400/#404 policy activation, original-caller #401 admission, SDK package composition and release/publication remain separate required gates. The current central-policy and PHP setup failures are not converted into acceptance by this verdict; no installed artifact or release is selected. |
|
Hosted runner rebind for the bounded source/composition PASS: PASS at the staged-binary scope for exact
This closes the runner/platform evidence that was pending in the source review. Repository integration remains HOLD: the current rollup has 20 successful contexts and 3 intended skips, but |



dw workflow:lstnow prioritizesworkflow:list. The default human help starts with the local Server, doctor, start, list, describe and history; profile/default-target guidance appears before the full option list.workflow:startputs an example and common options first, keeps advanced controls available, and presents--output=jsonwith--jsonas its existing alias.This branch now composes the exact reviewed native Server source from #161 (
59809483009aec9aa189058a3dc450a4a9830af8) with the reviewed help source (9e6bde1044edf6848a9f1adb4c5e7a8be1f7e96c). The runtime, filesystem guards, dependency lock and workflow pins are unchanged from #161. The merge preserves both catalog entries and all parity controls. The additional changes extend the existing staged-binary smoke test through saved-profile onboarding and correct the Rust README's obsolete Laravel-launch row.The same binary is tested with an empty PATH: native startup/readiness,
env:set,doctor, workflow start/list/describe/history, restart with identical run identity/history, platform admission and private-data refusals. These steps use no external PHP, Docker or Server executable at runtime. The test driver supplies disposable state and loopback requests.Validation:
20d547bdevelopment binary passes build, Clippy and the full empty-PATH profile/doctor/workflow/history/restart smoke. Its SHA256 ise542c574b6e9172bd96b6ebaf7d3cbee7e8584e7102d034cd470f417303d69c1; the public smoke script SHA256 iseab3773fd8eef719fb9c7ab5545248901c23b8adf8f78cd31eed9b299872c956. Exact-head hosted platform qualification also passes: Windows x64, Linux x64/ARM64 and macOS x64/ARM64 each run the native first-use smoke successfully. The full 2.x comparison and assembled assets pass.20d547b207f4f1acccdde4cb70863a6209c66023/ tree6d3487ac63d31bfb8bef2afbe4396e5d365caf4a.This remains draft. Central #400/#404 requires the already-requested organization ruleset administrator change, then shared input qualification and immutable adoption; central #401 admits the Rust 1.99 original caller. The SDK composition feature still needs its qualified package publication. The current failures are the central policy source binding and PHP 8.3 archive setup (HTTP 404 before tests), followed by their target-branch aggregate. The policy-gated original unit/PHAR jobs remain skipped. Repair/adoption, normal merges and released-binary first-use acceptance remain required. No release or broader profile admission is claimed.
Refs #159. Delivery is recorded after the installed CLI contains the changes.