Skip to content

Guide CLI first use and prioritize nearby command suggestions - #162

Draft
rmcdaniel wants to merge 10 commits into
mainfrom
cli/command-discovery
Draft

rmcdaniel wants to merge 10 commits into
mainfrom
cli/command-discovery

Conversation

@rmcdaniel

@rmcdaniel rmcdaniel commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

dw workflow:lst now prioritizes workflow:list. The default human help starts with the local Server, doctor, start, list, describe and history; profile/default-target guidance appears before the full option list. workflow:start puts an example and common options first, keeps advanced controls available, and presents --output=json with --json as its existing alias.

This branch now composes the exact reviewed native Server source from #161 (59809483009aec9aa189058a3dc450a4a9830af8) with the reviewed help source (9e6bde1044edf6848a9f1adb4c5e7a8be1f7e96c). The runtime, filesystem guards, dependency lock and workflow pins are unchanged from #161. The merge preserves both catalog entries and all parity controls. The additional changes extend the existing staged-binary smoke test through saved-profile onboarding and correct the Rust README's obsolete Laravel-launch row.

The same binary is tested with an empty PATH: native startup/readiness, env:set, doctor, workflow start/list/describe/history, restart with identical run identity/history, platform admission and private-data refusals. These steps use no external PHP, Docker or Server executable at runtime. The test driver supplies disposable state and loopback requests.

Validation:

  • Composed Rust tests pass: 327 ordinary tests, including the actual SDK Worker/durable timer and native data guards. The two generated-PHP differential tests remain separate from that count.
  • All 27 parity-harness controls pass, including both the exact completion-row comparison and field-scoped help exceptions. Exit codes, structured output and configuration remain compared.
  • The exact 20d547b development binary passes build, Clippy and the full empty-PATH profile/doctor/workflow/history/restart smoke. Its SHA256 is e542c574b6e9172bd96b6ebaf7d3cbee7e8584e7102d034cd470f417303d69c1; the public smoke script SHA256 is eab3773fd8eef719fb9c7ab5545248901c23b8adf8f78cd31eed9b299872c956. Exact-head hosted platform qualification also passes: Windows x64, Linux x64/ARM64 and macOS x64/ARM64 each run the native first-use smoke successfully. The full 2.x comparison and assembled assets pass.
  • Independent exact composition/runner review passes on 20d547b207f4f1acccdde4cb70863a6209c66023 / tree 6d3487ac63d31bfb8bef2afbe4396e5d365caf4a.
  • Independent hosted runner/platform rebind passes. Ordinary published-Server parity, CodeQL, Sonar and public-boundary checks also pass on the exact current head.

This remains draft. Central #400/#404 requires the already-requested organization ruleset administrator change, then shared input qualification and immutable adoption; central #401 admits the Rust 1.99 original caller. The SDK composition feature still needs its qualified package publication. The current failures are the central policy source binding and PHP 8.3 archive setup (HTTP 404 before tests), followed by their target-branch aggregate. The policy-gated original unit/PHAR jobs remain skipped. Repair/adoption, normal merges and released-binary first-use acceptance remain required. No release or broader profile admission is claimed.

Refs #159. Delivery is recorded after the installed CLI contains the changes.

@rmcdaniel rmcdaniel left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bounded ordinary source/help review at exact 7d85685f84989132afda46cadb92328c191e0b5e: one acceptance gap, detailed inline. The starting path does not include the history step explicitly required by #159.

I read the seven changed files and the surrounding lookup/dispatch, descriptor, output-mode and connection-resolution code. The suggestion ranking changes only the visible NotFound alternatives, after exact/alias/abbreviation lookup; existing confirmation and noninteractive failure paths remain. Human workflow:start help puts the concrete invocation and common controls first. Raw and namespace listings retain their layout paths. --output=json and the retained --json flag both select JSON; http://localhost:8080 is the actual unconfigured target after the existing explicit/environment/profile precedence. Catalog comparison confirms only the declared workflow:start help field changes, and its reviewed reference/candidate pair matches base/head. Display exceptions are confined to stdout_text or stderr; exit, JSON, config and error-category comparisons remain.

This is source/help review only. I ran no compiler, CLI binary, Server, SDK or test suite and do not independently certify the reported CI/platform/parity results. The #161 first-start dependency, PHP setup block and release/profile gates remain separate. Please add the missing history discovery step and update the focused assertion before this review can pass.

Comment thread rust/src/descriptor/txt.rs Resolved

@rmcdaniel rmcdaniel left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bounded ordinary source/help countercheck: PASS at exact 9e6bde1044edf6848a9f1adb4c5e7a8be1f7e96c.

The prior #159 acceptance finding is closed. The initial human path now includes workflow:history, while dw env:set profile guidance remains visible before the full options/reference. The focused assertion checks history discovery and visible profile guidance instead of fixing the row count at six. Raw, namespace-specific and error-header paths remain outside the onboarding addition.

I independently compared the exact successor against reviewed 7d85685f: one file only, three additions/nine deletions, covering that array and its focused assertion. All other lookup, catalog, descriptor and parity files are unchanged, so the remaining source/help conclusions in my earlier review carry forward without a new finding.

This is a source/help verdict. I ran no build, CLI, Server, SDK or tests and do not independently certify the reported nine descriptor tests. Current-head qualification, parent #161's first-start journey, the shared setup block and existing administrator/package/release gates remain separate.

@rmcdaniel

Copy link
Copy Markdown
Member Author

Security/source review: PASS for exact 9e6bde1044edf6848a9f1adb4c5e7a8be1f7e96c / tree 87a23a4a6acf5602676e7ae560104a55b9f588da.

The command lookup change is display-only after normal resolution has failed. Exact names, aliases, unambiguous abbreviations, namespace refusal, ambiguity handling, hidden-command filtering and the noninteractive failure remain unchanged. Suggestions are static catalog names; prioritizing the exact requested namespace and edit distance cannot execute a suggestion. The new control explicitly distinguishes the existing abbreviation dispatch from typo refusal.

The first-use and workflow:start changes are confined to human text rendering. Raw listings and namespace-specific listings retain their structure, structured descriptors retain their schema, and every option remains present; only the human workflow:start view groups the existing common and advanced controls. The catalog change is the single reviewed help value.

The parity exceptions are closed to stdout_text or stderr for the named cli#159 cases. The added harness control proves they cannot excuse an exit-code, JSON, configuration or error-category regression. I found no credential rendering, terminal-derived command execution or new network/file effect in this delta.

Delivery remains correctly held behind #161 composition: this exact base still has the pre-#161 Laravel-project server:start-dev, so the advertised first-use journey is not an installed standalone-native result on this head. The shared PHP setup/target-branch failure under central #404 also remains material. Require an exact composed-head rebind and installed first-use exercise after those dependencies; this source PASS does not infer either.

@sonarqubecloud

Copy link
Copy Markdown

@rmcdaniel

Copy link
Copy Markdown
Member Author

Security bounded source/composition/runner review: PASS for exact 20d547b207f4f1acccdde4cb70863a6209c66023 / tree 6d3487ac63d31bfb8bef2afbe4396e5d365caf4a.

The composition boundary is closed:

  • merge 397a030403932b3515522be71a9775ce6c31757e has exactly reviewed help parent 9e6bde1044edf6848a9f1adb4c5e7a8be1f7e96c and reviewed native parent 59809483009aec9aa189058a3dc450a4a9830af8;
  • Git remerge shows the sole manual conflict was rust/parity/catalog-updates.json; canonical JSON at the merge is byte-data-equivalent to the object union of both parent files (normalized SHA-256 8e75e92d… on each side), retaining both workflow:start and server:start-dev entries;
  • every effectful native Server file, filesystem guard, Cargo pin and workflow remains byte-identical to 5980948; the composed merge adds only the already-reviewed command-help/catalog side from 9e6bde1;
  • the direct child changes only scripts/ci/smoke-native-dev.py and rust/README.md.

The runner extension exercises the actual first-use path rather than bypassing profile resolution. Under an isolated HOME/config/temp and empty PATH it saves and selects local, invokes doctor without per-command server/token flags, starts a workflow through that profile, then lists, describes and reads nonempty history through the same profile. After restarting the same private data directory on a new ephemeral port, it rebinds the saved profile, requires the same run identity and requires the complete history array to remain unchanged. The existing held-directory/link/ownership and storage-admission refusals remain in the same staged-binary run. Successful doctor and later calls also prove the saved token is usable; the script does not print or inspect the token. The README now accurately calls the native Server linked and unreleased, with exact revisions owned by Cargo files rather than claiming a published crate.

Independent source checks pass: git diff --check, strict JSON parsing for the catalog/cases, exact python3 -I -S import/argument startup, and all 27 parity-source tests. No source/composition/runner finding remains in this bounded delta.

The live platform jobs, central #400/#404 policy activation, original-caller #401 admission, SDK package composition and release/publication remain separate required gates. The current central-policy and PHP setup failures are not converted into acceptance by this verdict; no installed artifact or release is selected.

@rmcdaniel

Copy link
Copy Markdown
Member Author

Hosted runner rebind for the bounded source/composition PASS: PASS at the staged-binary scope for exact 20d547b207f4f1acccdde4cb70863a6209c66023.

Rust release dry run 43611034021 is terminal SUCCESS on this exact head. All five release assets—Windows x86_64, Linux x86_64, Linux arm64, macOS x86_64 and macOS arm64—built successfully, and every platform-specific Exercise the built-in native development Server step passed the empty-PATH profile/doctor/start/list/describe/history/restart and filesystem-admission smoke. The downloaded Linux asset also passed the complete 2.x CLI comparison, and release-asset assembly passed. The ordinary published-Server parity job in run 43611033956 is separately SUCCESS.

This closes the runner/platform evidence that was pending in the source review. Repository integration remains HOLD: the current rollup has 20 successful contexts and 3 intended skips, but Central action policy preflight and Test (PHP 8.3) still fail on the shared #400/#404 activation/archive problem, and Target branch qualification reflects those failures. No bypass, old setup evidence, SDK package admission, merge, tag or release is cleared here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant