Repository navigation
Better rpath fix - #790
Merged
Merged
Better rpath fix#790
Conversation
This reverts commit 0db1a5b.
tianon
approved these changes
Jan 20, 2023
tianon
reviewed
Jan 20, 2023
| \ | ||
| # https://github.com/docker-library/python/issues/784 | ||
| # prevent accidental usage of a system installed libpython of the same version | ||
| bin="$(readlink -ve /usr/local/bin/python3)"; \ |
Member
There was a problem hiding this comment.
+ readlink -ve /usr/local/bin/python3
readlink: unrecognized option: e
BusyBox v1.35.0 (2022-11-19 10:13:10 UTC) multi-call binary.
Usage: readlink [-fnv] FILE
Display the value of a symlink
-f Canonicalize by following all symlinks
-n Don't add newline
-v Verbose
+ bin=Classic BusyBox 😄
Not the libraries in /usr/local/lib/python3.x/lib-dynload/ since they use system libraries like libssl (so `$ORIGIN/../lib` doesn't work for them)
yosifkit
force-pushed
the
better-rpath
branch
from
January 20, 2023 23:26
c3d7ff2 to
a1af335
Compare
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jan 21, 2023
Changes: - docker-library/python@6aba522: Merge pull request docker-library/python#790 from infosiftr/better-rpath - docker-library/python@a1af335: Only change rpath for python3.x binary - docker-library/python@5de3a27: Revert "Fix path to libpython shared-library in python binaries"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts #785 and then only changes rpath for python3.x binaries and not the libraries in
/usr/local/lib/python3.x/lib-dynload/since they use system libraries like libssl (so$ORIGIN/../libdoesn't work for them).Hopefully this should also fix issues like #786 or #787
Broken, current version: