Repository navigation
Conversation
Signed-off-by: dimakis <dimitri.saridakis@gmail.com>
Owner
Author
|
@codex review Please review this fork-only supervisor patch against All work belongs in |
dimakis
commented
Oct 17, 2026
dimakis
left a comment
Owner
Author
There was a problem hiding this comment.
Centaur Review
LGTM — no issues found.
Convergence
Recommendation: merge — No blocking in-scope findings remain.
- New blocking findings: 0
- Unresolved blocking findings: 0
- Non-blocking follow-ups: 0
- Repeated/deferred findings: 0
- Verified resolved findings: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optional optimization; rollout deferred. Mitzo PR ai-openshell#986 works with the existing pinned supervisor and is qualified independently. Measure that application change against the current stack before deciding whether a supervisor rollout is worthwhile. This PR is not a prerequisite for that Mitzo fix.
Provider-neutral warm sandboxes can receive an authenticated exec immediately after the gateway attaches a provider, before their periodic settings poll installs that provider's environment. Wake the existing reconciliation owner on exec so it can fetch and verify the new provider snapshot promptly. The application continues to verify the actual child environment before starting work.
This is a supervisor-only patch against the exact deployed source,
6ed9a64473615e05224a67b8cee49579a7cf95bc. It does not select an image, update the production lock, deploy a gateway or CLI, or activate production. The accompanying application fix is dimakis/mitzo#986.The patch adds in-memory notification state and changes neither persisted credential formats nor credential protocol/schema. Its adoption would still need a separately planned supervisor-image rollout under existing ownership and retention rules. A broader OpenShell upgrade or credential migration is outside this patch. Publication and any later adoption remain exclusively on the user's
dimakis/OpenShellfork.Related Issue
No separate issue required: localized correction to the existing provider-refresh path, directly requested after the production warm-start regression was measured. Five production Luna pairs measured warm native initialization at 10.52 seconds median and first text at 21.18 seconds, versus 0.29 and 10.45 seconds cold. These are baseline measurements, not results from this patch.
Changes
Testing
mise run pre-commitpasses, including workspace Clippy, formatting, license, documentation, protocol, Helm, Python and TypeScript checks.mise run ciwas attempted and stops on pre-existing Go formatting insdk/go/openshell/v1/internal/converter/coverage_test.go. The file's SHA-256 is identical to the baseline (d18a3a16ec2cf3760f6ecd276ab8fdf3161cce2b5eac4a2998d3d423f89312cf). Full CI is not claimed green.Checklist