Repository navigation
Conversation
Signed-off-by: dimakis <dimitri.saridakis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Controllers that read a provider version cannot preserve that read boundary through
provider update: the CLI currently sendsresource_version=0and permits a concurrent change to be overwritten. Add--expected-resource-version VERSIONand forward the nonzero version to the gateway’s existing compare-and-swap.Related Issue
No issue required: localized CLI bug fix forwarding the gateway’s existing optimistic-lock field. This supports Mitzo’s explicitly enrolled credential replacement flow in dimakis/mitzo#773.
Changes
Testing
mise run pre-commitpassescargo test -p openshell-cli --lockedpasses 513 tests; the 51-test provider integration suite passes.mise run ciwas attempted; its existingtest:e2e-parityshell fixture fails on macOS BSD sed (invalid command code f). The CLI tests and full pre-commit checks pass separately. No installation or deployment changed.Checklist