Skip to content

fix(supervisor): wake provider reconciliation for fresh exec - #4

Open
dimakis wants to merge 1 commit into
codex/mitzo-supervisor-6ed9a64from
fix/warm-provider-refresh
Open

dimakis wants to merge 1 commit into
codex/mitzo-supervisor-6ed9a64from
fix/warm-provider-refresh

Conversation

@dimakis

@dimakis dimakis commented Oct 17, 2026 •

Copy link
Copy Markdown
Owner

Summary

Optional optimization; rollout deferred. Mitzo PR ai-openshell#986 works with the existing pinned supervisor and is qualified independently. Measure that application change against the current stack before deciding whether a supervisor rollout is worthwhile. This PR is not a prerequisite for that Mitzo fix.

Provider-neutral warm sandboxes can receive an authenticated exec immediately after the gateway attaches a provider, before their periodic settings poll installs that provider's environment. Wake the existing reconciliation owner on exec so it can fetch and verify the new provider snapshot promptly. The application continues to verify the actual child environment before starting work.

This is a supervisor-only patch against the exact deployed source, 6ed9a64473615e05224a67b8cee49579a7cf95bc. It does not select an image, update the production lock, deploy a gateway or CLI, or activate production. The accompanying application fix is dimakis/mitzo#986.

The patch adds in-memory notification state and changes neither persisted credential formats nor credential protocol/schema. Its adoption would still need a separately planned supervisor-image rollout under existing ownership and retention rules. A broader OpenShell upgrade or credential migration is outside this patch. Publication and any later adoption remain exclusively on the user's dimakis/OpenShell fork.

Related Issue

No separate issue required: localized correction to the existing provider-refresh path, directly requested after the production warm-start regression was measured. Five production Luna pairs measured warm native initialization at 10.52 seconds median and first text at 21.18 seconds, versus 0.29 and 10.45 seconds cold. These are baseline measurements, not results from this patch.

Changes

  • Add a shared, coalescing notification to the existing credential state; it carries no credential values or readiness acknowledgement.
  • Wake the monolithic settings-poll owner on authenticated nonempty SSH exec requests, bounding request-driven polling to one start per 250 ms and preserving periodic idle polling.
  • Keep the existing validation and credential-installation path, current verified child snapshot, policy ownership and process-only sidecar behavior.
  • Document the behavior and add a focused Linux CI workflow with no model calls or production operations.

Testing

  • mise run pre-commit passes, including workspace Clippy, formatting, license, documentation, protocol, Helm, Python and TypeScript checks.
  • Unit regressions cover cloned-state notifications, signals before waiting, coalescing, unchanged credential snapshots, and waking a 60-second policy poll within one second.
  • Synthetic SSH integration exercises the real handler without a model or production service.
  • 292 component checks pass (37 credential, 117 sandbox policy, 138 supervisor/process), with one existing ignored process test.
  • The fork's focused Linux CI passes at the exact patch head: 187 checks (37 credential, 117 sandbox policy, 33 SSH), Rust formatting and Clippy for the changed crates. Inherited Branch Checks and Helm status placeholders await NVIDIA's upstream mirror; no upstream mirror is requested for this fork-only patch.
  • Full mise run ci was attempted and stops on pre-existing Go formatting in sdk/go/openshell/v1/internal/converter/coverage_test.go. The file's SHA-256 is identical to the baseline (d18a3a16ec2cf3760f6ecd276ab8fdf3161cce2b5eac4a2998d3d423f89312cf). Full CI is not claimed green.
  • No post-fix production measurement or container rollout has been performed.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture and published provider documentation updated

Signed-off-by: dimakis <dimitri.saridakis@gmail.com>
@dimakis

dimakis commented Oct 17, 2026

Copy link
Copy Markdown
Owner Author

@codex review

Please review this fork-only supervisor patch against codex/mitzo-supervisor-6ed9a64, with particular attention to credential snapshot safety, notification coalescing and cancellation, settings-poll ownership, Linux SSH integration, and whether the tests establish the claimed behavior. The exact head is fc7e2908c3df467514697ad7ff436e43b93c4849.

All work belongs in dimakis/OpenShell; do not open any PR or publish anything to NVIDIA upstream. This PR contains no deployment or production activation.

@dimakis dimakis left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Centaur Review

LGTM — no issues found.

Convergence

Recommendation: merge — No blocking in-scope findings remain.

  • New blocking findings: 0
  • Unresolved blocking findings: 0
  • Non-blocking follow-ups: 0
  • Repeated/deferred findings: 0
  • Verified resolved findings: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant