Repository navigation
Extract duplicated string literals into constants in reader (java:S1192) - #754
Merged
Merged
Conversation
Refs dfa1#738 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract the duplicated
"chunk"and"filter"parameter-name literals in the reader module'sComputeclass into private constants (java:S1192).The constant values are unchanged, so runtime behavior is unchanged. This PR covers the reader module only, as the issue asks for one PR per module.
Refs #738
Tests
.\mvnw.cmd verify -pl reader -am: fails inZstdBuffersEncodingDecoderTest(11 failures, 3 errors) with an error opening the extractedlibzstd.dllon my Windows machine. The same failure occurs on a clean checkout ofupstream/main, so it is not introduced by this change. I have not identified the underlying cause and could not run those tests locally; I would appreciate CI confirming them..\mvnw.cmd verify -pl reader -am "-Dtest=*Test,!ZstdBuffersEncodingDecoderTest" "-Dsurefire.failIfNoSpecifiedTests=false": passed (2,516 tests, 0 failures, 0 errors; partial run, Zstd test class excluded)..\mvnw.cmd verify -pl reader -am -DskipTests: passed.AI assistance: GitHub Copilot SDK in VS Code, Codex , Claude and ChatGPT. I reviewed the implementation and test results.