Repository navigation
Decode the decimal min/max of a flat node's stats - #740
Merged
Merged
Conversation
dfa1
force-pushed
the
fix/decimal-stats-710
branch
from
November 12, 2026 21:21
af8bad9 to
7d26daf
Compare
Rust writes a decimal bound as the little-endian two's-complement bytes of its unscaled value (1, 2, 4, 8, 16 or 32 bytes, ScalarValue::to_proto). The parser read every bytes_value as text, so a decimal bound never ordered and a filtered scan could not prune on it. ArrayStatsParser.parse takes the column dtype and builds a BigDecimal from the dtype's scale; an invalid width is rejected as Rust's bytes_from_proto does, which readFlatStats already reads as no stats. No vortex-jni cross-check: 0.93 writes no min/max on a decimal root node (byte parts or plain), so the path is only reachable from a file Rust writes with those stats; the unit tests pin Rust's encoding at every width. Fixes #710 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dfa1
force-pushed
the
fix/decimal-stats-710
branch
from
November 12, 2026 21:23
7d26daf to
8acb012
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #710
Rust writes a decimal stat bound as the little-endian two's-complement bytes of its unscaled value (1, 2, 4, 8, 16 or 32 bytes;
ScalarValue::to_proto/bytes_from_protoat 0.93.0). The parser read everybytes_valueas text, so a decimal bound never ordered and a filtered scan could not prune on it.ArrayStatsParser.parse(fbs, dtype)now builds aBigDecimalwith the column's scale. An invalid width is rejected as Rust does, whichreadFlatStatsalready reads as no stats.No vortex-jni cross-check: 0.93 writes no min/max on a decimal root node (byte parts or plain), so the path is unreachable from files it writes. Unit tests pin Rust's encoding at every width, negative values and negative scale.
🤖 Generated with Claude Code