Repository navigation
perf(writer): sum a segment only for the legacy zone map that reads it - #712
Merged
Merged
Conversation
SegmentEncoder summed every segment, and DictColumnState every dict chunk, for the zone-map SUM column. Only the legacy vortex.stats zone map writes that column: vortex.zoned (the default edition) records no zone sum (#447), and with zone maps off nothing reads it. So the sum is now taken only when the legacy zone map is written; files are unchanged. JavaVsJniWriteBenchmark.javaWrite (OHLC 10M rows, depth 3, -f 2, interleaved): 1.082/1.072 -> 1.149/1.133 ops/s, about 6%, half of what the file statistics (#664) added. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dfa1
force-pushed
the
skip-unused-segment-sums
branch
from
November 8, 2026 13:30
036b049 to
dba8b72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The writer summed every segment (and every global-dict chunk) for the zone-map SUM column, which only the legacy
vortex.statszone map writes;vortex.zoned(default) has no zone sum (#447). Spotted while profiling #706.Now summed only when the legacy zone map is written. Files are unchanged; the legacy-edition interop tests still cover the sums.
JavaVsJniWriteBenchmark.javaWrite(OHLC 10M rows, depth 3, -f 2, interleaved A/B): 1.082/1.072 → 1.149/1.133 ops/s, ~6% faster.🤖 Generated with Claude Code