Skip to content

refactor(core): move ArrayStats to core.model (#664) - #705

Merged
dfa1 merged 1 commit into
mainfrom
array-stats-to-core
Nov 8, 2026
Merged

dfa1 merged 1 commit into
mainfrom
array-stats-to-core

Conversation

@dfa1

@dfa1 dfa1 commented Nov 8, 2026

Copy link
Copy Markdown
Owner

First of three PRs for #664 (write summary).

ArrayStats moves from reader to core.model so the writer can return the statistics it writes. FlatBuffer parsing stays in the reader as the public ArrayStatsParser, the same split as ExtensionMetadata/ExtensionMetadataParser.

Next: write and read the footer's file statistics (Rust writes them by default; we write none), then VortexWriter#finish() returning a WriteSummary.

🤖 Generated with Claude Code

@dfa1
dfa1 force-pushed the array-stats-to-core branch from 1571020 to 0e13264 Compare November 8, 2026 09:17
The writer cannot depend on the reader, so it could not hand back the
statistics it writes. ArrayStats is a plain value and moves to
core.model; the FlatBuffer parsing stays in the reader as
ArrayStatsParser, the same split as ExtensionMetadata and
ExtensionMetadataParser.

First step towards a write summary returned by VortexWriter (#664).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@dfa1
dfa1 force-pushed the array-stats-to-core branch from 0e13264 to 8e850e5 Compare November 8, 2026 09:19
@dfa1
dfa1 merged commit e1622c1 into main Nov 8, 2026
6 checks passed
@dfa1
dfa1 deleted the array-stats-to-core branch November 8, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant