Repository navigation
refactor(core): move ArrayStats to core.model (#664) - #705
Merged
Merged
Conversation
dfa1
force-pushed
the
array-stats-to-core
branch
from
November 8, 2026 09:17
1571020 to
0e13264
Compare
The writer cannot depend on the reader, so it could not hand back the statistics it writes. ArrayStats is a plain value and moves to core.model; the FlatBuffer parsing stays in the reader as ArrayStatsParser, the same split as ExtensionMetadata and ExtensionMetadataParser. First step towards a write summary returned by VortexWriter (#664). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dfa1
force-pushed
the
array-stats-to-core
branch
from
November 8, 2026 09:19
0e13264 to
8e850e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of three PRs for #664 (write summary).
ArrayStatsmoves fromreadertocore.modelso the writer can return the statistics it writes. FlatBuffer parsing stays in the reader as the publicArrayStatsParser, the same split asExtensionMetadata/ExtensionMetadataParser.Next: write and read the footer's file statistics (Rust writes them by default; we write none), then
VortexWriter#finish()returning aWriteSummary.🤖 Generated with Claude Code