Skip to content

fix(reader): a decimal flat-node bound read as text no longer fails a filtered scan (#583) - #704

Merged
dfa1 merged 1 commit into
mainfrom
fix/583-decimal-flat-stats
Nov 8, 2026
Merged

dfa1 merged 1 commit into
mainfrom
fix/583-decimal-flat-stats

Conversation

@dfa1

@dfa1 dfa1 commented Nov 8, 2026

Copy link
Copy Markdown
Owner

A flat node's stats scalar is decoded without the column dtype, so a decimal bound reached Compare as a String and a filtered scan threw VortexException. canPrune now treats a non-BigDecimal decimal bound as absent (no pruning from it).

Tests: unit test fails without the guard (... String ... is not comparable to a decimal); decimal MIN/MAX push-down cases (whole table, filtered) in DecimalSumTest; small-file filtered read of a vortex-jni decimal file. clean verify of core, reader, writer, calcite, integration passed before the rebase; reader, writer, calcite re-verified after it.

The last open #583 item, nullable text with nulls training FSST on placeholder rows, needs validity inside the encodings and moves to #650.

🤖 Generated with Claude Code

https://claude.ai/code/session_011fRbYsrGtpKHp9APhU8qDV

… filtered scan (#583)

A flat node's stats scalar is decoded without the column dtype, so a decimal
min/max arrived as a String and Compare threw VortexException during chunk
pruning. canPrune now treats a non-BigDecimal decimal bound as absent.

Also pins decimal MIN/MAX push-down (whole table and filtered) in
DecimalSumTest and a small-file filtered read of a vortex-jni decimal file.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011fRbYsrGtpKHp9APhU8qDV
@dfa1
dfa1 merged commit f21266f into main Nov 8, 2026
6 checks passed
@dfa1
dfa1 deleted the fix/583-decimal-flat-stats branch November 8, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant