You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Simplify AssertJ assertions flagged by Sonar (java:S5838) #736
SonarCloud flags 23 assertions that have a more specific AssertJ form, e.g. assertThat(map.get(k)).isEqualTo(v) should be assertThat(map).containsEntry(k, v). The more specific form gives a better failure message.
Where: reader 17 (e.g. ComputeTest:708, :767), writer 3, and one each in fsst, calcite, integration. List: java:S5838 open issues.
How: pick one module, say so in a comment here, and send one PR. Test-only and behavior-neutral: ./mvnw test -pl <module> -am must stay green. Keep the // Given / // When / // Then structure. See CONTRIBUTING.md.
Beware: AssertJ's containsExactly on big arrays is quadratic; do not use it to replace isEqualTo on arrays.
Activity