Repository navigation
Conversation
|
@SaKaNa-Y is attempting to deploy a commit to the NuxtLabs Team on Vercel. A member of the Team first needs to authorize it. |
|
👁️🗨️ Review this pull request with grouped, summarized diffs at: raw result💭 analyzed by {
"headSha": "b2f9b23f103a95d80dd7cab8d1e9255561cf2db9",
"result": {
"overallSummary": "Fixes a bug where assigning a shortcut already bound to a command hidden by the current UI mode (e.g. Float Mode hidden while a popup is open) gave no conflict warning, letting a duplicate binding silently steal the shortcut once modes switched back. The fix checks conflicts against all bindable commands regardless of visibility while still filtering the visible settings list by mode, and adds targeted unit tests for the new conflict-detection helper.",
"groups": [
{
"key": "shortcut-conflict-fix",
"label": "Cross-mode shortcut conflict check",
"summary": "Adds `findKeybindingConflict`, which checks for duplicate shortcuts across all bindable commands (including those hidden by the current mode, e.g. Float Mode hidden behind a popup) instead of only visible ones, and wires it into the settings warning logic while keeping the visible list filtered by mode.",
"category": "ui",
"filePaths": [
"packages/hub-ui/src/client/state/keybindings.ts",
"packages/hub-ui/src/client/components/views-builtin/SettingsShortcuts.vue"
],
"fileNotes": [
{
"path": "packages/hub-ui/src/client/state/keybindings.ts",
"text": "Conflict detection now scans `getShortcutRows` (all bindable commands) rather than the mode-filtered rows previously used in SettingsShortcuts.vue, so hidden commands like Float Mode in a popup are no longer missed."
}
]
},
{
"key": "tests",
"label": "Keybinding conflict tests",
"summary": "Adds test coverage for `findKeybindingConflict`: hidden/nested commands, disabled shortcuts, excluding the edited command itself, and effective bindings with cleared or overridden defaults.",
"category": "tests",
"filePaths": [
"packages/hub-ui/src/client/state/keybindings.test.ts"
],
"critical": false
}
],
"schemaVersion": 1,
"source": "llm",
"generatedAt": "2026-10-07T07:30:38.557Z",
"model": "vercel-ai-gateway/anthropic/claude-sonnet-5",
"locale": "en"
}
} |
SaKaNa-Y
marked this pull request as ready for review
October 7, 2026 07:33
Contributor
Author
|
This fixes an issue introduced by vitejs/devtools#502 and reported in vitejs/devtools#524. The issue is that users receive no conflict warning when they assign the same shortcut to different commands across dock modes. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Please take a moment to read this. Thank you!
I should include a brief explanation of the problem in my own words in every PR. If that explanation is missing, please @mention me and do not merge this PR until I have added it. You may also leave this PR unaddressed (because this means I have not fulfilled my responsibilities as the author).
If my explanation is unclear or difficult to follow, please ask me to clarify or provide reproduction steps or supporting evidence.
I welcome suggestions and counterarguments, especially questions about anything I may have overlooked. (Your feedback helps me learn and improve. 🙏)
I hold myself to this standard for every PR, regardless of its size.
Assign a shortcut to Float Mode, open the popup window, and assign the same shortcut to Open Settings. The editor gives no conflict warning because Float Mode is hidden in the popup. Both commands become available again when the popup closes, so the duplicate binding can prevent one command from receiving the shortcut.
Check effective bindings across all commands that allow shortcuts, including commands hidden by the current mode. Keep the settings list filtered by mode and continue to allow saving after a warning. Tests cover hidden and nested commands, disabled shortcuts, the edited command, and cleared or overridden bindings.
Validation:
@devframes/hub-ui-onboard, which omit the existingdefaultMessagesexport. Both failures also reproduce with the three changed source files restored to unmodified HEAD.