Repository navigation
Refuse five unattested readings: bon, dí, heer as particles; herren, heren as titles (#766) - #919
Merged
Merged
Conversation
…n and heren as titles (#766) None had a recorded source or an attested use in a person's name, and each is borne as a name. Each reading becomes an exclusion quoting the evidence; the words keep or gain dated name readings (heer: Census 2010 surname 2,007, Wikidata family 113). PARTICLES loses bon, dí and heer; TITLES loses herren and heren, which also leaves AFTER_GIVEN_TITLES. Marie Bon Durand reads middle 'Bon', family 'Durand' (1.4.0-2.6.0: family 'Bon Durand'); Herren Hans reads given 'Herren' (was title); Doe, Jan Heren reads middle 'Heren' again, as 1.4.0-2.5.0 did. No committed corpus name moves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #766.
Carries out #766's proposal: five vocabulary readings with no attested use in a person's name are replaced by exclusions quoting the evidence, and each word keeps or gains dated name readings.
bondíheerrank)herrenherenafter_givenmark)Compiled sets:
PARTICLES−3,TITLES−2,AFTER_GIVEN_TITLES−1 (heren).und.tomlstill holds both its words (now name readings and exclusions), so it is not empty and the build needed nothing new. The v1 shim needs nothing either: a word removed from the vocabulary simply leaves v1's defaulttitles/prefixes, assadid.What moves
Grid over all three name orders and the comma shapes, against master (6ae585f):
Marie Bon Durand→ middleBon, familyDurand(was familyBon Durand, 1.4.0 through 2.6.0);Li Dí WangandJan Heer Smitthe sameHerren Hans→ givenHerren(was titleHerren);Heren Janthe sameDoe, Jan Heren→ middleHeren: back to 1.4.0 through 2.5.0's reading (2.6.0 read titleHerenvia rules/H8)Bon/Dí/Heerno longer reportsparticle-or-givenJohan de heer Van Kampenreads middlede heer, familyVan Kampen; no test or doc example held itEach claim above was checked against the 1.4.0, 2.5.0 and 2.6.0 wheels.
Committed corpora: no moves (
test_snapshot.py, CLDR, GND, Wikidata native and locale views all match their records), so nothing was re-recorded.Local corpora (
measure.py --base): 79 entries moved: ctgov-officials 14, fec-individuals 9, jrc-names 30, psc-individuals 20, tse-donors 6; nepal-candidates, tw-donors and ukec-individuals none. By shape:de Heer,le Bon,van Bon,di/dal Bon): this used to be an all-particle family. Now the word is the base, soinitials()stops counting the particle (K. d. H.→K. H.), and case repair writes the particle as it does for any particle surname. Turned up by the measurement, not predicted: it's an improvement.Bon/Heergiven name (Korean and FilipinoBon) loses itsparticle-or-givenreport.Herren/Herenopening a name → given name instead of title (3 entries, one of them a Brazilian given nameHeren).Heer/Bonis no longer lowercased by forced case repair (Dhillon-Heer,Bon-Kwon).Accepted cost (please confirm): a compound surname written with
Bonas its own first word, e.g. the ItalianX Bon Valsassinaand the stage nameBon Jovi, now reads middleBon. That is how any double surname reads by position;Policy(two_family_names=True)reads it right. jrc-names reads 5 more persons' spellings alike.Docs, same diff
und.tomlStanding bullet revised, Should bon, dí, heer, herren and heren stay in the vocabulary? None is attested in a person's name #766 removed fromOpen:, and a dated Log entry with the measurement and its recompute recipeherenleft the salutationsunddescription, and therankexample (heer→freiherrin)I left
decidedoff the exclusions: that's for you to add once you accept them.Checks
Full suite (32,083 passed),
-n0 -m serial(43 passed; an earlier run failed its wall-clock ratios under load 40, and the base checkout failed the same way under that load),sphinx-build -b doctest docs,python -m doctest README.rst, ruff, mypy,build.py --check.🤖 Generated with Claude Code