Skip to content

Revisit how BIN_MIN and BIN_MAX are specified in das2stream #155

Open

Description

@jbfaden

Chris asked about the format for das2streams with error bars and bounaries. Autoplot can export a dataset with min and max to a das2stream using code Chris wrote:

if ( checkOperation.equals("BIN_MAX") ) {

Autoplot wasn't picking this up in its reader (it looks like there was a branch which would handle this but it was turned off and threw an error when I tried it). I've made it so that the branch it was taking looks for the .min and .max extentions. (mydata.max is the maximum observed value in the interval, mydata.min is the minimum.)

Note too that Autoplot doesn't show error bars by default. They are detected, though, and the scientist can enable them with the checkbox on the style tab.

Chris also asks that stddev be added, and these will be handled the same way. Though these look different in the QDataSet data model, Autoplot (and Das2) draws error bars and extremes the same way.

Activity

  1. added a commit that references this issue on Dec 10, 2025
  2. jbfaden commented on Dec 10, 2025

    @jbfaden
    MemberAuthor

    I've added stddev, and it looks like Autoplot automatically turns on the error bars in this case. Look for the next release. Also I'll add tests so this doesn't revert again. (I saw some comments by me about changing behavior in 2021, so clearly we need to lock in this functionality.

  3. added a commit that references this issue on Dec 10, 2025
  4. jbfaden commented on Dec 10, 2025

    @jbfaden
    MemberAuthor

    Actually I'm going to reopen this because there's an old d2s parser and new one which goes straight to QDataSet, not via the old data model. I thought this new one was in production use, but apparently that's not the case. I'm going to fix this as well so there isn't a surprise in the future, and we should work towards using the new parser.

  5. added a commit that references this issue on Dec 10, 2025
  6. jbfaden commented on Dec 10, 2025

    @jbfaden
    MemberAuthor

    The new parser also handles this properly.

  7. added a commit that references this issue on Dec 10, 2025
  8. cpiker commented on Dec 10, 2025

    @cpiker
    Member

    Nice to go straight to QDataSet and skip the middleman. Do you plan to do any dead code removal on the old parser to prevent confusion, or keep it in main for quick reference?

  9. jbfaden commented on Dec 10, 2025

    @jbfaden
    MemberAuthor

    There must be some reason why we/I switched back to the old one, but yes I think we would want to get rid of the code. It's also the only part of the system that uses the old data model so it would be good to get rid of it for that reason too. I'll start a ticket for that, too, but honestly I don't know who would be interested in funding that effort.

  10. jbfaden commented on Feb 4, 2026

    @jbfaden
    MemberAuthor

    #158. The new parser handles this properly now.

  11. reopened this on Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions