Repository navigation
lib/dtutils/string: don't fail when version name metadata is missing - #722
Open
paulglover wants to merge 1 commit into
Open
paulglover wants to merge 1 commit into
paulglover wants to merge 1 commit into
Conversation
image.version_name exists only when the version name metadata field is configured. If a user removed it in metadata preferences, reading it raises, so build_substitute_list fails on every image. Callers such as rename_images then stop mid-job and leave their progress bar running. The metadata preferences tag picker cannot add Xmp.darktable.version_name back, so users have no way to recover from the UI. Read the field through pcall and substitute an empty string when it is absent. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
So the real bug is that you can't add Xmp.darktable.version_name back to metadata editor. You should raise an issue with darktable and tag @zisoft |
Contributor
Author
|
Will do, I was thinking this one over and agree that’s the real issue in this case.Cheers,Paul.On Nov 14, 2026, at 9:52 PM, wpferguson ***@***.***> wrote:wpferguson left a comment (darktable-org/lua-scripts#722)
So the real bug is that you can't add Xmp.darktable.version_name back to metadata editor. You should raise an issue with darktable and tag @zisoft
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
image.version_nameis only registered ondt_lua_image_twhen the version name metadata field is configured. If a user removes that field in metadata preferences, reading it raisesfield "version_name" not found for type dt_lua_image_trather than returning nil, sobuild_substitute_listfails on every image, whatever the pattern.The visible symptom is in
contrib/rename_images: the error escapes its job loop beforestop_jobruns, so nothing gets renamed and the "renaming images" progress bar stays up for the rest of the session. The metadata preferences tag picker only lists exiv2 namespaces, soXmp.darktable.version_namecan't be added back from the UI.This change reads the field through
pcalland substitutes an empty string when it is absent.$(VERSION.NAME)behaves as before when the field is configured.Tested in darktable 5.6.0 with the version name field removed: rename_images now completes.
🤖 Generated with Claude Code