Skip to content

Intro animation and sign-in screen UI - #68

Open
durualayli wants to merge 1 commit into
mainfrom
duru/intro-signin
Open

durualayli wants to merge 1 commit into
mainfrom
duru/intro-signin

Conversation

@durualayli

Copy link
Copy Markdown
Contributor
score.mp4

Tried doing stacked PRs so I hope they work 🤞🤞 This one is just for the intro animation and the sign-in view UI.

  • Intro animation from the Figma design: the logo bounces in, rings ripple out, and the sport icons fly in from off screen and shake before the logo moves up
  • Sign-in view with the Sign Up, Log In and Sign Up Later buttons, which fade in after the intro animation finishes
  • The sign-in view isn’t connected to the app yet and the buttons don’t do the actual sign-in. That’s in the next PR.

Next steps (next PR):

  • Google sign-in with the backend (login / sign-up)
  • Onboarding: edit profile and favorite sports
  • Welcome banner on the Upcoming page

@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4383ed72-3647-419c-bfaf-aa2fc3034626
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zainbilalh zainbilalh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The animation looks great! Just one comment, and also I think we should have a separate folder with subfolders to organize all these files. @JiwonJeong414 what do you think?

"scale" : "1x"
},
{
"filename" : "Speaker 1.png",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these files names should be Speakerx1 Speakerx2 and Speakerx3

@JiwonJeong414

Copy link
Copy Markdown

yeah I agree, maybe like components in the subfolders in each view directory?

}

// MARK: - Keyframes

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are more like constants

}

private extension IntroAnimationView {
@KeyframesBuilder<Wobble>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woah nice work you are so smart

@zainbilalh zainbilalh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick review. It looks great lol I'm very excited to have this in the app

@@ -0,0 +1,63 @@
//
// SportsIcon.swift

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Should be SportIcon


import SwiftUI

import SwiftUI

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SwiftUI imported twice


@State private var showIntro = !SignInView.hasShownIntro
@State private var showButtons = SignInView.hasShownIntro
static var hasShownIntro = false

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this shouldn't be owned by the view itself and should be owned by @AppStorage because I'm assuming we want to play this once when the app is installed? At least this version with the sign in.

SportIcon("Soccer-g", x: 160, y: 145),
SportIcon("Tennis-g", x: -133, y: 194),
SportIcon("Baseball-g", x: 82, y: 202),
SportIcon("Equestrian-g", x: -32, y: 208),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an image for equestrian?


extension SportIcon {
static let all: [SportIcon] = [
SportIcon("Golf-g", x: 46, y: -202),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be done later, but I think we should have a sport struct/enum that also returns the image name so we don't have a bunch of magic strings here.

This is how FilterTile currently does it:
let imageName: String = selected ? sport.rawValue+"-r": sport.rawValue+"-g"

I'm thinking we extend the enum for sport with a selected image and grey image function that returns the correct name for the image, and here it would be smth like:
SportIcon(Rowing.selectedImage, x: -74, y: -190),


// MARK: - Animation

func startAnimation(onFinished: (() -> Void)?) async {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this but looking at the code, what happens when startAnimation returns before calling onFinished?()?

Like if one of the awaits fails or the task is cancelled, does the animation never end?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants