Skip to content

Add highlight favoriting UI and sign-in prompt - #125

Draft
EmilJiang wants to merge 1 commit into
highlights-ui-splitfrom
highlight-favoriting
Draft

EmilJiang wants to merge 1 commit into
highlights-ui-splitfrom
highlight-favoriting

Conversation

@EmilJiang

@EmilJiang EmilJiang commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Stacked on #139 (highlights-ui-split). Merge order: #137 → #139 → #125.

Adds a corner bookmark control to the existing article and video cards. Tapping it while signed out opens “Sign In to Save”; Close, Not now, and Back dismiss the prompt. Preserves #139’s highlights navigation, search, card links, styling options, and video overlays.

Account availability and favorite state remain local booleans. Sign In and Create an Account are placeholders; authentication navigation and saving highlights to an account are deferred. Hardcoded previews use local images in the debug source set and have been updated for #139’s date model.

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@EmilJiang
EmilJiang force-pushed the highlight-favoriting branch from 8430387 to 4a7b85d Compare November 18, 2026 21:13
@EmilJiang
EmilJiang changed the base branch from main to highlights-ui-split November 18, 2026 21:13
@EmilJiang
EmilJiang added this pull request to stack #147 November 18, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant