Skip to content

Add favorite sports selection screen - #122

Merged
EmilJiang merged 1 commit into
mainfrom
edit-favorite-sports
Nov 10, 2026
Merged

EmilJiang merged 1 commit into
mainfrom
edit-favorite-sports

Conversation

@EmilJiang

@EmilJiang EmilJiang commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Stacked on #120; targets populated-profile.

The Favorite Sports Edit button opens a three-column selector with All/Men’s/Women’s filters. Selected sports appear first with green borders and remove badges. Tapping a sport adds or removes that division, and going back updates the profile favorites.

Screenshot 2026-10-28 at 2 14 00 PM

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 06b8a576-045e-4abb-a674-4efaacd0b17c
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@EmilJiang
EmilJiang added this pull request to stack #121 October 28, 2026 18:14
@EmilJiang
EmilJiang requested a review from caleb-bit October 28, 2026 18:18

@caleb-bit caleb-bit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, left a few comments.

@EmilJiang
EmilJiang requested a review from caleb-bit November 4, 2026 19:47
@EmilJiang

Copy link
Copy Markdown
Contributor Author

Thanks for review just added the changes

Base automatically changed from populated-profile to main November 4, 2026 22:17

@caleb-bit caleb-bit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good work

@EmilJiang
EmilJiang force-pushed the edit-favorite-sports branch from f42d78e to 47f8df4 Compare November 10, 2026 18:59
@EmilJiang
EmilJiang merged commit 77a5ceb into main Nov 10, 2026
6 checks passed
@EmilJiang
EmilJiang deleted the edit-favorite-sports branch November 10, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants