Repository navigation
[exec.domain.default] add static to the member itemdecls - #9392
Merged
jensmaurer merged 1 commit intoNov 17, 2026
Merged
Conversation
The synopsis has declared transform_sender and apply_sender static since P2300R10 (1e38639), but their itemdecls never did. P3826R5 shows the transform_sender itemdecl as static, but does not mark static as an insertion, so 79d1055 did not add it (while adding indeterminate_domain::transform_sender as static in both synopsis and itemdecl).
Member
|
itemdecl 's refer to the declarations in the header in an unambiguous way, but don't have to repeat it verbatim. In particular, a missing "static" doesn't seem to be a grave problem. Do we usually put "static" into the itemdecl? |
Contributor
Author
I count 130 itemdecls in the entire draft that say static (of them 84 are static member functions) Besides these two default_domain itemdecls, the only other missing static appears to be thread::hardware_concurrency in [thread.thread.static], whose jthread counterpart has static itemdecl |
Member
|
Ok, thanks. |
jensmaurer
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The synopsis has declared default_domain's transform_sender and apply_sender static since P2300R10 (1e38639), but their itemdecls never did.
P3826R5's wording actually shows the transform_sender itemdecl as static, but does not mark static as an insertion, so 79d1055 did not add it (while adding indeterminate_domain::transform_sender as static in both synopsis and itemdecl).