Skip to content

Fix custom event arguments - #65

Merged
jlbooker merged 1 commit into
corejavascript:masterfrom
Tol1:fix-custom-event-args
Nov 10, 2016
Merged

jlbooker merged 1 commit into
corejavascript:masterfrom
Tol1:fix-custom-event-args

Conversation

@Tol1

@Tol1 Tol1 commented Mar 1, 2016

Copy link
Copy Markdown

Unmerged pull request from author of upstream twitter/typeahead.js#1207
Rebased original to be mergeable
Closes #63 and #58

@Tol1
Tol1 force-pushed the fix-custom-event-args branch from 82b6f36 to 332738d Compare March 1, 2016 13:34
@fscq86

fscq86 commented Mar 1, 2016

Copy link
Copy Markdown

+1 waiting for this fix

@jlbooker jlbooker added this to the v0.11.2 milestone Mar 2, 2016
@JoeyDB

JoeyDB commented Apr 19, 2016

Copy link
Copy Markdown

Is there any temporary fix until v0.11.2 comes out? Thanks!

@ThisIsAreku

Copy link
Copy Markdown

👍 This might be at least merged to a dev branch

@jlbooker

jlbooker commented Nov 1, 2016

Copy link
Copy Markdown
Contributor

@Tol1 Any chance you could rebase again and update this PR? We're working towards a release soon, and it'd be good to include this fix.

@jlbooker jlbooker closed this Nov 1, 2016
@jlbooker jlbooker reopened this Nov 1, 2016
@jlbooker jlbooker added the bug label Nov 1, 2016
@Tol1

Tol1 commented Nov 1, 2016

Copy link
Copy Markdown
Author

I'll rebase as soon as I have time
Great to hear about new release!

@Tol1
Tol1 force-pushed the fix-custom-event-args branch from 332738d to e7fb159 Compare November 2, 2016 13:36
@Tol1

Tol1 commented Nov 2, 2016

Copy link
Copy Markdown
Author

Rebased, this should be mergeable now

@jlbooker

jlbooker commented Nov 2, 2016

Copy link
Copy Markdown
Contributor

👍 Thanks @Tol1 . @CoreSystemDevelopment Could you give this a review as well?

@jlbooker jlbooker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlbooker

jlbooker commented Nov 9, 2016

Copy link
Copy Markdown
Contributor

Also probably fixes #89

@jlbooker

Copy link
Copy Markdown
Contributor

Hi @aaaa0441, I think you put your comment on the wrong issue. This is the crejavascript fork that's being maintained. :-)

@aaaa0441

Copy link
Copy Markdown

oops, my bad. Thanks, @jlbooker, for keeping this project maintained! =) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants