Repository navigation
fix: minor build fixes - #5039
Conversation
The lines were a bit off.
This gets overidden in the standalone but it was getting uselessly included in the npm package.
jsjoeio
left a comment
jsjoeio
left a comment
There was a problem hiding this comment.
Might be worth adding a small description to the PR as well
| # - Some extensions have a .gitignore which excludes their built source from | ||
| # the npm package so exclude any .gitignore files. | ||
| # - Exclude Node as we will add it ourselves for the standalone and will not | ||
| # need it for the npm package. | ||
| rsync -avh --exclude .gitignore --exclude /node ./lib/vscode-reh-web-*/ "$VSCODE_OUT_PATH" |
There was a problem hiding this comment.
I am not seeing a .gitignore in the typescript-language-features extension so probably not unfortunately 😢
Will comment more on that issue; planning on getting through all my GitHub notifs today
| --- code-server.orig/lib/vscode/src/vs/code/browser/workbench/workbench.ts | ||
| +++ code-server/lib/vscode/src/vs/code/browser/workbench/workbench.ts | ||
| @@ -350,19 +350,6 @@ class WorkspaceProvider implements IWork | ||
| @@ -410,19 +410,6 @@ class WorkspaceProvider implements IWork |
There was a problem hiding this comment.
Does this fix that weird space thing we were seeing?
There was a problem hiding this comment.
I am not sure if we are talking about the same thing but this fixes the warning output by quilt push -a since the patch is slightly off.
Codecov Report
@@ Coverage Diff @@
## main #5039 +/- ##
=======================================
Coverage 71.30% 71.30%
=======================================
Files 30 30
Lines 1683 1683
Branches 373 373
=======================================
Hits 1200 1200
Misses 413 413
Partials 70 70 Continue to review full report at Codecov.
|
* Regenerate last opened patch The lines were a bit off. * Remove packaged .gitignore files Fixes coder#4964. * Remove extra Node binary This gets overidden in the standalone but it was getting uselessly included in the npm package.
See commits for list of fixes.