Skip to content
This repository was archived by the owner on May 21, 2025. It is now read-only.
This repository was archived by the owner on May 21, 2025. It is now read-only.

CircleCI: inconsistent args for build/job with codecov-python #221

Open

Description

@blueyed

https://github.com/codecov/codecov-bash/blob/7e6cfa3935aeb29de57298bda496dad27b24aa37/codecov#L541-L542

vs

build=os.getenv('CIRCLE_BUILD_NUM') + "." + os.getenv('CIRCLE_NODE_INDEX'),
job=os.getenv('CIRCLE_BUILD_NUM') + "." + os.getenv('CIRCLE_NODE_INDEX'),

build=os.getenv('CIRCLE_BUILD_NUM') + "." + os.getenv('CIRCLE_NODE_INDEX'),
job=os.getenv('CIRCLE_BUILD_NUM') + "." + os.getenv('CIRCLE_NODE_INDEX'),

Activity

  1. drazisil commented on Nov 18, 2019

    @drazisil
    Contributor

    This may be a bug in the python uploader, or it is handled differently. The bash uploader correctly handles CircleCI build URLs.

  2. blueyed commented on Nov 20, 2019

    @blueyed
    ContributorAuthor

    @drazisil
    Ok. Can you move the issue there then?
    (This issue just documents / points out that they differ - I cannot say which is correct, but they should be the same)

  3. self-assigned this
    on Nov 29, 2020
  4. removed their assignment
    on Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions