Skip to content

Use non-blocking output for stdout #47

Closed

Description

@WyriHaximus

Went through the source and came across https://github.com/clue/php-stdio-react/blob/0c9a7fe7a87643499c56dc5af63c3e497b717d79/src/Stdout.php#L11 noting STDOUT is used in a blocking manner. Is there anything special that needs to be done, or can be be wrapped into a WritableResourceStream and hooked into the loop easily?

Activity

  1. clue commented on Jun 24, 2017

    @clue
    Owner

    I suppose this is related to #6, but we'd have to look into this. Do you feel like filing a PR? 👍

    For the reference: The WritableResourceStream didn't exist back when this repo has been created and part of the motivation for creating that class was actually for this repo :shipit:

  2. WyriHaximus commented on Jun 24, 2017

    @WyriHaximus
    Author

    Do you feel like filing a PR?

    Working on https://github.com/wyrihaximus/reactphp-psr-3-stdio so yeah I'm up for filing a PR 😀 .

    For the reference: The WritableResourceStream didn't exist back when this repo has been created and part of the motivation for creating that class was actually for this repo :shipit:

    I'm aware, found out that file it from 2014 no worries 👍

  3. WyriHaximus commented on Jul 7, 2017

    @WyriHaximus
    Author

    Note that the two referenced PR's are in I've started working on this 🎉

  4. WyriHaximus commented on Jul 10, 2017

    @WyriHaximus
    Author

    Interesting enough my current local code closes STDOUT and cuts phpunit output 🤐

  5. modified the milestones: , v2.0.0 on Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedExtra attention is needednew featureNew feature or request

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions