Skip to content

fix(website): skip the dependents probe when deleting previews - #844

Merged
cameri merged 2 commits into
mainfrom
fix/preview-delete-force
Oct 16, 2026
Merged

cameri merged 2 commits into
mainfrom
fix/preview-delete-force

Conversation

@chappie-daemon

Copy link
Copy Markdown
Collaborator

The preview cleanup step's wrangler delete probes the account's KV namespaces to warn about dependents — a call the deploy token (Workers Scripts scope only) cannot make, so it printed Authentication error [code: 10000] after the delete had already succeeded and the || echo caught the exit. The worker was deleted fine; the error was noise.

--force skips exactly that probe. Preview workers are assets-only (no bindings), so the check is pure overhead. A missing worker still errors and the || echo catches it, as before.

Also carries a changeset so the release gate is satisfied.

wrangler delete probes the account's KV namespaces to warn about
dependents — a call the deploy token (Workers Scripts scope only) cannot
make, so it errored with auth 10000 after the delete had already
succeeded. --force skips that probe; preview workers are assets-only
with no bindings, so the check is pure overhead. A missing worker still
errors and the || echo catches it.
@changeset-bot

changeset-bot Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: eaab999

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
nostream-website Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

🧹 Site preview for this PR was deleted (PR closed).

@greptile-apps

greptile-apps Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This PR appears safe to merge; no actionable issues were found.

Summary

Adds --force to preview-worker deletion to skip the dependents probe.

  • Closing a pull request deletes its preview without the KV probe.

Reviews (1) · Last reviewed commit: "fix(website): skip the dependents probe ..." · Reviewed by Greptile

@cameri
cameri merged commit c352d72 into main Oct 16, 2026
13 checks passed
@cameri
cameri deleted the fix/preview-delete-force branch October 16, 2026 17:33
@cameri
cameri temporarily deployed to website-preview October 16, 2026 17:33 — with GitHub Actions Inactive

This branch was previously deployed

1 inactive deployment
website-preview — eaab9996 Deployed Oct 16, 2026 by cameri via preview #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants