Repository navigation
fix(cli): gate the unix-only migration APIs behind cfg(unix) #1148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
927ba72
fix(cli): gate unix-only migration apis behind cfg(unix) (#1121)
tirthraj01 1f618f1
fix(cli): gate the last unix-only call sites behind cfg(unix)
chappie-daemon 22ef684
fix(cli): gate the ancestry check and pin the non-Unix refusal
chappie-daemon c9d29c5
chore(cli): drop the scratch message file from the previous commit
chappie-daemon 0c70d93
fix(config): import OsStr only where the unix trim uses it
chappie-daemon d188623
fix(ci): pin the Windows job's actions by tag, like every other job
chappie-daemon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| --- | ||
| --- | ||
|
|
||
| Gate Unix-only migration APIs and directory permissions behind cfg(unix) (#1121) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| //! The `migrate pg-to-lmdb` command where the copy cannot run: every part of it needs Unix file | ||
| //! modes, so the command still exists but refuses, and this file pins what it answers. | ||
| //! | ||
| //! The copy, the manifest, resume and verify live in `migrate_cli.rs`, which compiles only on | ||
| //! Unix. CI runs this one from the `windows-latest` job. | ||
|
|
||
| #![cfg(not(unix))] | ||
| #![allow(clippy::unwrap_used, clippy::expect_used, clippy::panic)] | ||
|
|
||
| use std::process::Command; | ||
|
|
||
| /// The refusal names the command, says the platform is the reason, and exits non-zero, so an | ||
| /// operator reading a pipeline log learns why rather than seeing a compile error or a hang. | ||
| #[test] | ||
| fn the_command_is_refused_with_a_named_reason_and_exit_1() { | ||
| let directory = tempfile::tempdir().expect("a temporary directory"); | ||
| let output = Command::new(env!("CARGO_BIN_EXE_nostream-cli")) | ||
| .args(["migrate", "pg-to-lmdb", "--target"]) | ||
| .arg(directory.path()) | ||
| .output() | ||
| .expect("the binary runs"); | ||
|
|
||
| assert_eq!(output.status.code(), Some(1), "the refusal exits 1"); | ||
| let stdout = String::from_utf8_lossy(&output.stdout); | ||
| assert!( | ||
| stdout.contains("migrate pg-to-lmdb is unsupported on this platform"), | ||
| "the refusal names the command and the reason: {stdout}" | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.