Skip to content

fix: reject sub with unsafe ints in since/until - #114

Merged
cameri merged 1 commit into
mainfrom
110-error-error-value-1672295751103-is-out-of-range-for-type-integer
Dec 29, 2022
Merged

cameri merged 1 commit into
mainfrom
110-error-error-value-1672295751103-is-out-of-range-for-type-integer

Conversation

@cameri

@cameri cameri commented Dec 29, 2022

Copy link
Copy Markdown
Owner

Signed-off-by: Ricardo Arturo Cabral Mejía me@ricardocabral.io

Description

  1. Reject subscriptions with unsafe integers in since/until

Related Issue

#110

Motivation and Context

  1. Unsafe integers cause errors when querying the database

How Has This Been Tested?

  1. Unit tests

Screenshots (if appropriate):

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • All new and existing tests passed.

Signed-off-by: Ricardo Arturo Cabral Mejía <me@ricardocabral.io>
@cameri cameri added the bug Something isn't working label Dec 29, 2022
@cameri cameri self-assigned this Dec 29, 2022
@cameri cameri linked an issue Dec 29, 2022 that may be closed by this pull request
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@coveralls

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 3801785405

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 87.092%

Totals Coverage Status
Change from base Build 3801593164: 0.1%
Covered Lines: 837
Relevant Lines: 948

💛 - Coveralls

@cameri
cameri merged commit fe9ad92 into main Dec 29, 2022
@cameri
cameri deleted the 110-error-error-value-1672295751103-is-out-of-range-for-type-integer branch December 29, 2022 16:38
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.15.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Error] ERROR: value "1672295751103" is out of range for type integer

2 participants