Repository navigation
fix(cli): reject a SECRET that cannot be saved to .env and read back unchanged #1091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Priyanshubhartistm
wants to merge
11
commits into
cameri:main
Choose a base branch
from
Priyanshubhartistm:fix/cli-secret-hash-roundtrip
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
6b3db4d
fix(cli): reject a SECRET that cannot be saved to .env and read back …
Priyanshubhartistm fcb29a8
fix(cli): save a quoted secret typed at the prompt without its quotes
Priyanshubhartistm f2183ec
test(cli): run the setup spec against the source so its coverage is c…
Priyanshubhartistm d97bc6e
fix(cli): refuse a SECRET with a dollar sign, which Docker Compose ex…
Priyanshubhartistm f463468
fix(cli): apply the SECRET checks to config env set as well
Priyanshubhartistm c306598
fix(cli): keep config env validate working for a SECRET with a comment
Priyanshubhartistm 816470e
Merge branch 'main' into fix/cli-secret-hash-roundtrip
cameri 17d8658
Merge branch 'main' into fix/cli-secret-hash-roundtrip
Ferryx349 1cda032
fix(cli): refuse a SECRET with a backslash inside double quotes
Priyanshubhartistm 904e039
Merge branch 'main' into fix/cli-secret-hash-roundtrip
Priyanshubhartistm 0088191
Merge remote-tracking branch 'origin/fix/cli-secret-hash-roundtrip' i…
Priyanshubhartistm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "nostream": patch | ||
| --- | ||
|
|
||
| fix(cli): reject a SECRET that cannot be saved to .env and read back unchanged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.