Repository navigation
feat(peering): rate-limit on-demand requests from peers #1053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e37b284
feat(peering): rate-limit on-demand requests from peers
Ferryx349 7bbbfac
Merge branch 'main' into feat/peering-on-demand
Ferryx349 e16324f
fix(peering): close subscriptions and NIP-77 sessions during limiter …
Ferryx349 1ded94d
fix(peering): ignore stale limiter results after subscription close
Ferryx349 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| --- | ||
| "nostream": minor | ||
| --- | ||
|
|
||
| feat(peering): rate-limit on-demand requests from authenticated peers | ||
|
|
||
| Authenticated peers can request events outside their standing feed with a | ||
| normal `REQ`, `COUNT`, or ad-hoc `NEG-OPEN` session. Those requests continue to | ||
| use peer subscription and NIP-77 limits instead of client limits, and are now | ||
| bounded per peer pubkey by `limits.peer.request.rateLimits` (default 300 | ||
| requests/minute across `REQ`, `COUNT`, and `NEG-OPEN`). | ||
|
|
||
| Refused `REQ`/`COUNT` calls receive `CLOSED` with a `rate-limited:` reason and | ||
| retry hint; refused `NEG-OPEN` sessions receive `NEG-ERR`. The limiter fails | ||
| closed when its store is unavailable, and unidentified clients are unaffected. | ||
| Per-peer request/event accounting and admin-console visibility are left to the | ||
| dedicated admin-console follow-up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,11 @@ | ||
| import { IMessageHandler } from '../@types/message-handlers' | ||
| import { IWebSocketAdapter } from '../@types/adapters' | ||
| import { IMessageHandler } from '../@types/message-handlers' | ||
| import { UnsubscribeMessage } from '../@types/messages' | ||
| import { WebSocketAdapterEvent } from '../constants/adapter' | ||
|
|
||
| export class UnsubscribeMessageHandler implements IMessageHandler { | ||
| public constructor(private readonly webSocket: IWebSocketAdapter) {} | ||
|
|
||
| public async handleMessage(message: UnsubscribeMessage): Promise<void> { | ||
| this.webSocket.emit(WebSocketAdapterEvent.Unsubscribe, message[1]) | ||
| this.webSocket.endSubscription(message[1]) | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.