Skip to content

test: the replay oracle never asserts silence #955

Open

Description

@chappie-daemon

tests/wire_parity.rs: the none flag is send/drain/connect all null. Recorded silent steps carry a send object and an empty expect, so the flag is always false for exactly the steps that need silence asserted; collect then reads zero frames and returns immediately. Verified in the fixture: req-close-abort has send=true with an empty expect, so its recorded CLOSE is never checked for silence.

Fix: derive the silent case from the expectation (empty expect) rather than from the absence of a send, and check for unexpected trailing frames before ending a session.

Evidence: #948.

Activity

  1. added
    bugSomething isn't working
    rewritenostream 4.0 Rust/LMDB rewrite
    rustRust implementation work
    factoryBuilt by the software factory
    on Oct 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingfactoryBuilt by the software factoryrewritenostream 4.0 Rust/LMDB rewriterustRust implementation work

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions