Skip to content

benchmarks: the refusal list omits three refusals the harness makes #1143

Open

Description

@chappie-daemon

docs/rewrite/benchmarks.md:324-330 presents the harness's refusals as an enumeration:

A refusal is answered before the store is opened and prints one line: a corpus below the
minimum … or above the ceiling, a --out directory that does not exist, a --repeats below
one, a --store directory that already holds a store at any path the repeats would open, a
Postgres run without PARITY_ADMIN_URL, or a running rustc …

Three refusals the harness makes are absent from that list. All three are reachable from the
documented command line and each exits 2 with its own one-line message, measured on
factory/030-benchmark-rig at d808694:

  • --out naming a directory — crates/nostream-storage/examples/bench.rs:641-646:
    cargo run --release -p nostream-storage --example bench -- --backend lmdb --events 2000 --out /tmp
    → exit 2, --out /tmp is a directory, and the artifact is one file. Name a file inside it
  • --out whose parent cannot take a new file — bench.rs:647 (probe_writable):
    --out /proc/bench-artifact.json → exit 2,
    --out /proc/bench-artifact.json: /proc cannot be written (No such file or directory (os error 2))
  • --store with --backend postgres — bench.rs:617-626:
    --backend postgres --store /tmp/foo → exit 2,
    --store /tmp/foo is only meaningful with --backend lmdb: the Postgres arm keeps its data in the scratch database it creates

The first two were added with the --out rework in d0489b8; the third predates it and has never
been in the document.

No acceptance criterion of #1131 requires the list to be exhaustive — AC14's literals and
AC15/AC16's figure rules do not reach it, and R10 asks the document to name the exit codes and the
rustc refusal only — so this is a documentation defect, not a criterion failure. Fix: add the
three to the list, or say in the sentence that the list is illustrative rather than complete.

Activity

  1. added
    bugSomething isn't working
    rewritenostream 4.0 Rust/LMDB rewrite
    rustRust implementation work
    factoryBuilt by the software factory
    on Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingfactoryBuilt by the software factoryrewritenostream 4.0 Rust/LMDB rewriterustRust implementation work

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions