Skip to content

benchmarks: D9 lists 28 935 as an exception to a predicate it satisfies #1138

Open

Description

@chappie-daemon

Found by round 5's code lens of the benchmark rig (#1131, docs/rewrite/benchmarks.md), which recorded it as "should be fixed the next time this bullet is touched". It blocks nothing; the three kinds are each resolved explicitly two clauses later.

What

docs/rewrite/benchmarks.md:277-283 reads: "Ephemeral kinds 20000–29999 are never stored at all (…) and reach no repository call — except 28934, 28935 and 28936, which the invites and users arms claim before the ephemeral arm is reached (…)".

The except clause is an exception to which arm claims them, but it is attached to "reach no repository call", and 28935 satisfies that predicate: the InviteRequest arm is context.send_ok(event.id, false, "invalid: kind 28935 is issued by the relay, …") and touches no store (crates/nostream-relay/src/strategies/invite_request.rs:29-43 — no context.stores access). The sentence's own last clause says so, so it lists an exception that is not one for the predicate it names.

Acceptance

  • 28 935 moves out of the except list and is introduced as a kind the same selector claims and refuses without a store, e.g. "except 28 934 and 28 936, which the invites and users arms claim before the ephemeral arm is reached (strategies/mod.rs:90-96) …; 28 935 is claimed by the same block and refused without touching a store (invite_request.rs:29-43)".
  • The per-kind resolutions stay: 28 934 claim_code/admit_user (join_request.rs:100, :118), 28 936 revoke_admission (leave_request.rs:91).
  • No numeral changes meaning, so AC16 of the rig's spec still holds by inspection.

Related: #1131, #1132.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingfactoryBuilt by the software factoryrewritenostream 4.0 Rust/LMDB rewriterustRust implementation work

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions