Skip to content

config: a .nan value is reported twice by the settings validator #1050

Open

Description

@chappie-daemon

Found in job 022's security review (a note, not a blocker for #998).

A budget or cap written as .nan produces two issues from validate_document — one from the zero/ceiling shape walk and one from the whole-number check — where every other invalid form produces one. Measured: .nan → 2 issues, .inf → 1.

The consequence is a count an operator cannot reconcile (settings invalid: 2 issues for a single wrong value) and a validator whose issue list is not one-per-defect.

What it needs

  • Decide which rule owns the NaN case and make the other skip it, so one bad value is one issue.
  • A test pinning the count for .nan, .inf, -1, 1e40 and a quoted "NaN", so the one-per-defect property is asserted rather than assumed.

Measured in 022-settings-ceiling's round-2/review-security.md.

Activity

  1. added
    bugSomething isn't working
    rewritenostream 4.0 Rust/LMDB rewrite
    rustRust implementation work
    factoryBuilt by the software factory
    on Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingfactoryBuilt by the software factoryrewritenostream 4.0 Rust/LMDB rewriterustRust implementation work

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions