Skip to content

Don't let Coveralls failures gate merges - #191

Closed
rdlauer wants to merge 1 commit into
mainfrom
coveralls-non-blocking
Closed

rdlauer wants to merge 1 commit into
mainfrom
coveralls-non-blocking

Conversation

@rdlauer

@rdlauer rdlauer commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

The Coveralls publish step runs inside the build job, so any Coveralls error fails
the build — fail-fast cancels the rest of the matrix and the required ci-gate
goes red. Coverage reporting was effectively a merge gate even though the
coverage/coveralls status was never a required check.

It has blocked merges twice with every test passing:

continue-on-error: true on the publish step. A Coveralls failure now shows as a
warning on that step while the job, and ci-gate, still pass.

🤖 Generated with Claude Code

The publish step runs inside the build job, so any Coveralls error fails the
build: fail-fast cancels the rest of the matrix and the required `ci-gate` goes
red. A Coveralls 500 did exactly that on 2026-09-28 with all 419 tests passing,
and a 422 did it on #185.

The `coverage/coveralls` status was never a required check, but the publish
step's exit code effectively made it one. continue-on-error keeps coverage
reporting informational.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@rdlauer

rdlauer commented Sep 28, 2026

Copy link
Copy Markdown
Contributor Author

Folded into #190 at the author's request.

@rdlauer rdlauer closed this Sep 28, 2026
@rdlauer
rdlauer deleted the coveralls-non-blocking branch September 28, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant