Conversation
…m blocks in a plain loop instead of stepping a keystream index per byte, so Salsa20, XSalsa20, ChaCha and XChaCha20 run 1.3 to 1.75 times as fast Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
The patch looks good, but there doesn't appear to be an AI declaration on this - it's clearly done with AI assistance though. Please see CONTRIBUTING.md |
Contributor
Author
|
@dghgit sorry about that, AI disclosure note added to both ticket and PR (should it be only on one and not the other?). I found this wording of disclosure in another PR, hope this format is OK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…cks in a plain loop instead of stepping a keystream index per byte, so Salsa20, XSalsa20, ChaCha and XChaCha20 run 1.3 to 1.75 times as fast
See #2476 for detailed explanation and benchmarks.
AI Disclosure
Parts of this contribution were produced with the assistance of a generative AI tool (Claude Code),
under the direction and review of the submitter, in line with the contributing guidelines. The submitter
has reviewed and understands the code. To the best of his knowledge, the contribution does not reproduce third-party material.