Repository navigation
docs(sdk): conversation ownership and User entity limits for bulk update - #362
Draft
abrahams-wix wants to merge 4 commits into
Draft
abrahams-wix wants to merge 4 commits into
abrahams-wix wants to merge 4 commits into
Conversation
Add the ownership rule to the module description, getConversation, listConversations, createConversation, addMessage, and subscribeToConversation. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…e User entity Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
🚀 Package Preview Available!Install this PR's preview build with npm: npm i @base44-preview/sdk@0.8.57-pr.362.2ee7c13Prefer not to change any import paths? Install using npm alias so your code still imports npm i "@base44/sdk@npm:@base44-preview/sdk@0.8.57-pr.362.2ee7c13"Or add it to your {
"dependencies": {
"@base44/sdk": "npm:@base44-preview/sdk@0.8.57-pr.362.2ee7c13"
}
}
Preview published to npm registry — try new features instantly! |
…for a missing conversation Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ehavior Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JSDoc fixes from reader and Customer Care feedback.
This PR is stacked on #361. Its base is
docs-feedback-fixes, so the diff shows only these changes. Retarget it tomainonce #361 merges.Agents module (
packages/sdk/src/modules/agents.types.ts)base44.asServiceRole.agents, the module only reaches conversations created through the service role. It doesn't give your backend access to conversations that individual users created.getConversation()says the conversation must belong to the current user (otherwise a403error), and that a missing conversation fails with a404error.@returnsno longer says it resolves toundefined.listConversations(),createConversation(),addMessage(), andsubscribeToConversation()say the conversation belongs to the current user.Entities module (
packages/sdk/src/modules/entities.types.ts)updateMany()andbulkUpdate()say they aren't available for the built-inUserentity and fail with a405error.UpdateManyResult.updatedincludes records that already held the new values, because every update refreshesupdated_date.bulkUpdate()says the call checks every record before writing. If a check fails, no records change. If a write fails partway, earlier records stay written.JSDoc only, no code changes. I compared two generator runs to see which reference lines change. Those lines are in base44-dev/mintlify-docs#2925.
Points for reviewers to check
405for theUserentity is stable and meant to be public.getConversation()still returnsPromise<AgentConversation | undefined>and its example still has anif (conversation)guard, but it now rejects with an error for a missing conversation. Should the type and example change?409. Should that be documented?🤖 Generated with Claude Code