Receive complete OSC UDP datagrams larger than 8192 bytes - #196
Open
Meowthos503 wants to merge 1 commit into
Open
Meowthos503 wants to merge 1 commit into
Meowthos503 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The synchronous OSC UDP servers inherit
socketserver.UDPServer's 8,192-byte receive limit. A valid larger OSC message or bundle is truncated before it reaches the dispatcher, so its callback can be silently skipped.Set the shared
OSCUDPServerreceive limit to 65,535 bytes, sufficient for complete standard UDP datagrams. Blocking, threading and forking servers inherit the fix. The regression modelsrecvfromtruncation and checks complete reception and callback delivery for a 9,000-byte blob both directly and inside a bundle.This addresses a reproducible large-packet failure that may explain reports such as #190; the reporter's exact VMC traffic was not available for verification.
Validation on Python 3.12.14:
AI-assisted implementation and independent AI review, submitted through the Meowthos503 account. The reported checks were executed locally.