This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Git identity panel stuck on in a non-git repo #2435
Copy link
Copy link
Closed
Labels
Description
Prerequisites
- Put an X between the brackets on this line if you have done all of the following:
- Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
- Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
- Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
- Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
- Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages
Description
When Atom is opened with a project root that is not a git repository, the "Git Identity" view is always shown (with empty username and email) even when both are set in the global config.
Steps to Reproduce
mkdir -p ~/src/not-gitatom ~/src/not-git
Expected behavior:
The "initialize a repo here" pane should be visible.
Actual behavior:
The "Git identity" pane is visible.
Reproduces how often:
100%
Versions
$ atom --version
Atom : 1.46.0-nightly7
Electron: 4.2.7
Chrome : 69.0.3497.128
Node : 10.11.0
$ apm --version
apm 2.4.3
npm 6.2.0
node 10.2.1 x64
atom 1.46.0-nightly7
python 2.7.16
git 2.24.1
Additional Information
My guess is that this is caused by the default implementation of State#getConfig() in non-Present repository states.
Activity